Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect PP display ingame #28006

Closed
Sunderw3k opened this issue Apr 26, 2024 · 4 comments
Closed

Incorrect PP display ingame #28006

Sunderw3k opened this issue Apr 26, 2024 · 4 comments

Comments

@Sunderw3k
Copy link

Type

Game behaviour

Bug description

My play shows 15pp ingame, while on the website its 16pp. The pp on website is technically 15.503 so I think there's a difference in rounding somewhere. Which one is the correct one?

Screenshots or videos

image
image

Version

2024.412.1-lazer

Logs

compressed-logs.zip
@novialriptide
Copy link
Contributor

You need to turn on Lazer mode for the website.

image

@Sunderw3k
Copy link
Author

All my scores are set on lazer, if i turn off the mode my profile is empty.

bdach added a commit to bdach/osu-tools that referenced this issue Apr 29, 2024
@bdach
Fix online attribute flag in score performance command not retrieving…
d6cf8dc 
… full difficulty attributes

Found when investigating ppy/osu#28006.

If the `performance score` command is given the `-a` flag, it is
supposed to use the current online beatmap difficulty attributes. It
does so by querying API, which queries `osu-beatmap-difficulty-cache`.

Problem is, that some of the difficulty attributes, namely the ones that
are already present on `APIBeatmap`, are not serialised out by
`osu-beatmap-difficulty-cache`:

	https://github.com/ppy/osu-beatmap-difficulty-lookup-cache/blob/db2203368221109803f2031788da31deb94e0f11/BeatmapDifficultyLookupCache/DifficultyCache.cs#L125-L128

`osu-tools` is blissfully unaware of this, and as such attempts to
deserialise the difficulty attributes returned from cache-then-web raw,
which leads to it just using the default values (e.g. zeroes) for
attributes that the difficulty lookup cache does not serialise out. This
leads to obviously bogus results.

To fix, retrieve the `APIBeatmap` manually and do some (admittedly
gnarly) grafting in order to produce a fully populated object. It's a
bit ugly but it works locally without further changes so maybe fine?
@bdach bdach mentioned this issue Apr 29, 2024
Merged
@bdach
Copy link
Collaborator

bdach commented Apr 29, 2024 •
edited

As far as I can tell neither side is "displaying wrong". It's just that local lazer PP doesn't match current live.

See excerpts from osu-tools below:

Using local beatmap attributes 
Performance attributes
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
aim                 : 6.863
speed               : 4.130
accuracy            : 3.975
flashlight          : 0.000
effective miss count: 0.000
pp                  : 15.494
Using online beatmap attributes 
Performance attributes
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
aim                 : 6.868
speed               : 4.133
accuracy            : 3.975
flashlight          : 0.000
effective miss count: 0.000
pp                  : 15.503

tl;dr: One of the yet-to-be-deployed star difficulty/pp changes nerfed this beatmap slightly, which led your score to be nerfed from 15.503 pp to 15.494 pp - but this nerf only takes place locally for now, while live values are inflated until the pending changes are deployed.

I'm not sure we can or should be doing anything about this other than aiming to deploy the changes at some point. cc @ppy/team-client

@smoogipoo
Copy link
Contributor

There's nothing more to do than deploy changes.

@smoogipoo smoogipoo closed this as not planned Won't fix, can't repro, duplicate, stale Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smoogipoo @bdach @novialriptide @Sunderw3k