Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL3: tablet driver bug with a new lazer update #28223

Open
Zenicior opened this issue May 19, 2024 · 12 comments
Open

SDL3: tablet driver bug with a new lazer update #28223

Zenicior opened this issue May 19, 2024 · 12 comments

Comments

@Zenicior
Copy link

Type

Game behaviour

Bug description

After the newest lazer update ma tablet drivers work properly everywhere but not while in game. I have been using the same drivers for about 3 years now and I have been playing lazer exclusively for about 1.5 years and this is the first time that this thing has occurred. I'm not sure if it's visible on the video but it seems like the area of the tablet randomaly jumps on the screen and doesn't let me to move my cursor in any consistent way.

Screenshots or videos

tablet.drivers.working.but.only.outside.of.osu.mp4

Version

2024.519.1-lazer

Logs

compressed-logs.zip

@DBeitniz
Copy link

Idk if I can help, but have you disabled the tablet driver IN osu itself, it could just randomly turn on even though you didn't touched it (happened to me once)

@Zenicior
Copy link
Author

Idk if I can help, but have you disabled the tablet driver IN osu itself, it could just randomly turn on even though you didn't touched it (happened to me once)

yes, that is the first think that I checked and it's turned off

@AppleVlux
Copy link

I got the same issue but i think its because of the option: "High precision mouse" (Raw Input).

I recorded 3 demo's in separate versions (uploaded to streamable cause the video is too large):
https://streamable.com/hxpkip

@Zenicior
Copy link
Author

I got the same issue but i think its because of the option: "High precision mouse" (Raw Input).

I recorded 3 demo's in separate versions (uploaded to streamable cause the video is too large): https://streamable.com/hxpkip

omg thank you, it worked for me as well. I'm curious what coused that.

@Skrubbadubba
Copy link

Had this problem aswell, turning of raw input fixed it. It must have had something to do with this release. More specifically (for me atleast), the tablet behaved as if it was in relative mode (like a mouse). It also seemed like inputs were dropped if dragging the pen, or sometimes moving it too fast. Turning on the driver inside the client also fixed the problem even while raw input was still on.

@bdach
Copy link
Collaborator

bdach commented May 20, 2024

@Susko3 this is where i would question the original decision to remove the "custom WindowsMouseHandler mouse logic" in ppy/osu-framework#6234 which i presume is the root cause of this. what was the plan on this again?

@bdach bdach added osu!framework issue Can't resolve this without changes to osu!framework. type:input labels May 20, 2024
@Susko3
Copy link
Member

Susko3 commented May 20, 2024

Judging from this issue thread, it seems things are as broken as they used to be, but more people are affected. (I was under the impression that every tablet wasn't working with relative mode, but some actually worked fine with the now removed WindowsMouseHandler logic.)

Disabling relative mode still works around the issue, and enabling and using the built-in tablet driver fixes the issue.

At least all tablet/pen input should now be equally broken when using relative mouse mode.

All input handling code is now in SDL3, so that needs fixing. I have some theories about how to fix things, but I don't have a tablet to test with.

@bdach bdach removed the osu!framework issue Can't resolve this without changes to osu!framework. label May 20, 2024
@bdach
Copy link
Collaborator

bdach commented May 20, 2024

At least all tablet/pen input should now be equally broken when using relative mouse mode.

this sort of statement does not inspire confidence. we should not be regressing things that badly and justifying it with "well at least now it's as broken for everyone as it used to be for a small subset of users!".

as i see it either we revert the removal of the windows raw mouse handler or contribute the equivalent upstream. this situation cannot stay as is.

@Susko3
Copy link
Member

Susko3 commented May 20, 2024

we revert the removal of the windows raw mouse handler

The handler was primarily removed because it wasn't compatible with SDL3. I'll look into upstreaming.

@xekridi
Copy link

xekridi commented May 20, 2024

Turning off raw input helped me but now my sens isnt same. And i cant change it in-game, so overall it doesnt help

@Keelar69
Copy link

disabling raw input made my cursor completly stop moving. My tablet works jsut fine until I enter Lazer. Hopefully it will get fixed soon

@smoogipoo smoogipoo changed the title tablet driver bug with a new lazer update SDL3: tablet driver bug with a new lazer update May 29, 2024
@LYNK-INCUU
Copy link

I got the same issue but i think its because of the option: "High precision mouse" (Raw Input).

I recorded 3 demo's in separate versions (uploaded to streamable cause the video is too large): https://streamable.com/hxpkip

this solved my issue with tablet input not working when not using the ingame driver (opentabletdriver) on CTL-472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants