Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu-lazer android crashes on multi with russian language #6261

Open
ChibiSnoop opened this issue Sep 25, 2019 · 9 comments
Open

osu-lazer android crashes on multi with russian language #6261

ChibiSnoop opened this issue Sep 25, 2019 · 9 comments

Comments

@ChibiSnoop
Copy link

ChibiSnoop commented Sep 25, 2019

Describe the crash: : I have Redmi Note 5 with russian language on, basically, when i go into multi lobby, the game crashes and no problem issue. English language fixes it.

Screenshots or videos showing encountered issue:
Github doesn't allow videos, if you ask, i can send it here via youtube
Quick Edit: https://youtu.be/vGTRk0RrCO4 is the video, should note about after video, there's no error note

osu!lazer version:
2019.913.0 (multi on this version works with english, have tested it)

Logs: runtime[1].log and
network[1].log with
performance[1].log

Computer Specifications:
Redmi Note 5:
Snapdragon 636

4GB RAM

@l3lackShark
Copy link

This is essentially the same underlying issue as in #5279 (or very similar at least) even though the PR with fix for this was merged. I will try to reproduce this on my phone.

@l3lackShark
Copy link

l3lackShark commented Sep 25, 2019

Alright it seems that the issue still remains but the point of the crash have changed. It used to crash immediately after clicking on the Multi icon and now it lets you go a little bit further, but still crashes upon entering a room. See these for video comparison:

how it used to be

now

@ChibiSnoop
Copy link
Author

Made a quick update with how it looks on my device too

@bdach
Copy link
Collaborator

bdach commented Sep 25, 2019

Looking at the PR merged, it's not that the fix didn't work, but naked .Humanize() calls are all susceptible to similar failures on mobile, so every place that uses Humanizer raw instead of through HumanizerUtils might crash due to resource copy failures.

This is a tough call, since if we start working around Xamarin/Humanizer's brokenness everywhere then every .Humanize() call will have to be inspected. It would be helpful to have some sort of static analysis highlight this at CI-time if we decide to go this way. It might be necessary, unfortunately, since the Xamarin-side issues seem dead in the water.

@peppy
Copy link
Sponsor Member

peppy commented Sep 25, 2019

It should only affect calls where lookups involve string resources. Would be interested to see which call it is failing on now. We aren't the only affected by this, but there seems to be little progress on the underlying issue (dotnet/android#2012 (comment)).

We may want to just include the DLLs locally as a workaround.

@ChibiSnoop
Copy link
Author

So, I can close this issue now? Basically, the main problem has been revealed, or there might be any updates?(I know it is not relatable somehow)

@bdach
Copy link
Collaborator

bdach commented Sep 25, 2019

Please leave it open, it will be closed when the PR with the fix is merged. That is also when you'll know it got fixed.

@ChibiSnoop
Copy link
Author

Oh, okay

@ChibiSnoop
Copy link
Author

ChibiSnoop commented Sep 25, 2019

Okay, should say about new 925 version here.
It doesn't load multiplayer lobbies like It was in earlier versions(on russian and on english sys. languages).

On English(United States) sys. language it seems better, it loads lobbies and crashes. On russian sys. language it doesn't even try! But(again not relatable) it runs smoother on phone than 913
UPD:ok now it works on english sys. Language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants