Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a beatmap does not expand its group if the selected group is too low #816

Closed
marco-stephan opened this issue May 20, 2017 · 4 comments

Comments

@marco-stephan
Copy link
Contributor

marco-stephan commented May 20, 2017

Selecting a beatmap group header a few pixels above the footer will mark the group, but will not expand it. This can be easily reproduced by clicking through the footer.

I've tried to resolve this issue but couldn't succeed. It seems to be an issue with async loading. Normally when selecting a beatmap group, the isLoaded value of its first panel (which will be selected) is true. However, in the specific scenario explained above, this value is always false. It seems that the beatmap group's panels are not loaded until the beatmap group header is completly on screen.

Video example of this issue: https://streamable.com/gryk0

@marco-stephan
Copy link
Contributor Author

Resolved through #814.

@peppy peppy reopened this May 21, 2017
@peppy
Copy link
Sponsor Member

peppy commented May 21, 2017

please leave issues open until the PR that resolves them is merged. add a "Resolves #xxx" to the PR or commit description to automate the closing process

@marco-stephan
Copy link
Contributor Author

Ok, will do so from now on.

@peppy
Copy link
Sponsor Member

peppy commented May 21, 2017

Also for issues like this, a short video showing what is happening would be very useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants