No visual feedback on hit/miss slider tail on default skin

[Youlixx]

Describe the bug:
With the current slider scoring method, dropping a slider end results in a miss (not sure if this behavior is intended, since it breaks a lot of stable replays, and slider heavy maps are really hard to combo (not to mention 2B maps)). The miss sound is correctly played, however the miss texture is not displayed. The miss count is correct on the result screen.

Screenshots or videos showing encountered issue:
https://www.youtube.com/watch?v=i-NXnHX-vC0

osu!lazer version:
2020.408.1

[aemino]

Maybe I'm missing something and there's a more "correct" way to resolve this, but the following change seems to fix this issue on my end.

--- a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSliderTail.cs
+++ b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSliderTail.cs
@@ -15,7 +15,7 @@ public class DrawableSliderTail : DrawableOsuHitObject, IRequireTracking
         /// <summary>
         /// The judgement text is provided by the <see cref="DrawableSlider"/>.
         /// </summary>
-        public override bool DisplayResult => false;
+        //  public override bool DisplayResult => false;
 
         public bool Tracking { get; set; }

I can make a PR to remove this override if this is the correct solution.

[peppy]

That is not a valid fix and will break other pieces of the puzzle (likely giving double judgements to slider ends).

[aemino]

Hmm, it seems a bit odd that DisplayResult also controls scoring. What would be the proper way to fix this issue?

[smoogipoo]

It doesn't control scoring, but it would affect non-misses as well so there needs to be specific handling for slider tail judgements.

[peppy]

Renaming this issue to cover the fact that ticks do not show judgement, which is the underlying issue here.

[peppy]

Bringing this up-to-date since a lot has changed since it is reported:

In the current scoring we have, slider ends now count as a SmallTick, which means they affect accuracy but not combo. They are also not visually represented in all skins. Probably need to ask opinions of whether they should be showing a judgement or not (and if they are, what kind?).

Personally I think we need to somehow represent them visually as they are currently an invisible object on the (lazer) default skin. At which point, the DrawableHitObject's animation can probably cover the visual feedback required to let the user know if they've hit or missed.

One thing to then consider is user skins may have sliderendcircle skinned out to be empty, which makes the judgement once again invisible.

[peppy]

Removing from milestone as this is going to happen as part of the gameplay design refresh. Requirements have been conveyed to @arflyte, will assign to him for tracking.