Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use disposal in CheckBackgroundQuality #15552

Merged
merged 3 commits into from Nov 10, 2021

Conversation

Naxesss
Copy link
Contributor

@Naxesss Naxesss commented Nov 10, 2021

Applies #13871 (comment) to this check. Also adds a test failing prior to these changes.

(Figured I'd add such regression tests for the other checks too, but decided against it after a few attempts due to disposal being tricky to test well.)

@smoogipoo smoogipoo merged commit 9404eac into ppy:master Nov 10, 2021
@Naxesss Naxesss deleted the dispose-background-after-check branch November 10, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants