Fix legacy combo counter not fully hiding for rulesets that implement their own #16257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16250.
Regressed in #16000 due to taking the
popOutCountout ofcounterContainer. Fixed by putting it back in there, but keeping the anchor/origin andBypassAutoSizeAxes = Axes.Bothto not regress #15973.Test coverage added but it's purely visual. I can add asserts but due to the fact that both sprite texts have their own alpha transforms and their parent is what controls the flag seems kind of flaky to depend on implementation details of the counter (if such a test checking the parent's alpha existed, it could have not even failed with the changes at #16000, as only one of the sprite texts was taken out of its hidden parent).