Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add last played search filter in song select #23129
Add last played search filter in song select #23129
Changes from 4 commits
102576c
216a88e
6dead81
4b053b4
52adb99
d6c6507
0c1d6eb
df17051
c2f225f
928145c
8e156fd
8ba9677
1113355
f0f37df
d7dfc8b
c24328d
a8ae0a0
f1d69ab
414066f
f7bea00
ae9a266
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does anyone really want or need decimal months/years? Those are possibly the least intuitive units under the sun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with it being not intuitive (except maybe 0.5y). However, as the other units (d, h, m, s) accepts decimals it is to not make the search fail if decimal is used in y or M. I think it does not hurt the player if enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not hurt the player but it complicates implementation for little reason. I still say remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was gonna remove this myself but then saw other places already support decimal so decided not to bother in the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very misleading. There is no inverse of the equals operator defined, so this should probably throw. (Also the
default
branch doesn't make much sense).Function could be renamed to
reverseInequalityOperator()
to match this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed function as proposed because the previous name was indeed misleading. I also changed the default case to be an out of range exception for unsupported operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, the reverse of
Greater
isLessOrEqual
. Same goes for the rest.