Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not revert to default value when double-clicking disabled slider #25230

Merged
merged 5 commits into from
Oct 26, 2023
Merged

Do not revert to default value when double-clicking disabled slider #25230

merged 5 commits into from
Oct 26, 2023

Commits on Oct 26, 2023

  1. Add failing test coverage for double-click on disabled sliders

    @bdach
    bdach committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    910d74f View commit details
    Browse the repository at this point in the history

  2. Fix tests specifying float precision for double bindable 

    Would cause assignments to `.Value` to become imprecise even if the
underlying bindable could represent the value 100% accurately.
    @bdach
    bdach committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    96437c4 View commit details
    Browse the repository at this point in the history

  3. Fix cross-test data dependency by recreating slider every time

    @bdach
    bdach committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    89fec95 View commit details
    Browse the repository at this point in the history

  4. Do not revert to default value when double-clicking disabled slider 

    Closes ppy#25228.
    @bdach
    bdach committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3b9c4c9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into double-click-disabled-slider

    @frenzibyte
    frenzibyte committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    54b6933 View commit details
    Browse the repository at this point in the history