Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mod search textbox having focus while settings are visible #25857

Merged
merged 3 commits into from
Dec 19, 2023

Add test coverage of desired input handling behaviour

d793d1c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix mod search textbox having focus while settings are visible #25857

Add test coverage of desired input handling behaviour
d793d1c
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Linux, SingleThread) failed Dec 19, 2023 in 1s

Test Results (Linux, SingleThread) ❌

Tests failed

❌ TestResults-Linux-SingleThread.trx

5461 tests were completed in 1150s with 5409 passed, 1 failed and 51 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Gameplay.TestSceneArgonHealthDisplay 4✔️ 1❌ 10s

❌ osu.Game.Tests.Visual.Gameplay.TestSceneArgonHealthDisplay

✔️ TestConstructor
✔️ TestHealthDisplayIncrementing
✔️ TestLateMissAfterConsequentMisses
✔️ TestMissAlmostExactlyAfterLastMissAnimation
❌ TestMissThenHitAtSameUpdateFrame
	TearDown : System.TimeoutException : "wait for health" timed out

Annotations

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, SingleThread)

osu.Game.Tests.Visual.Gameplay.TestSceneArgonHealthDisplay ► TestMissThenHitAtSameUpdateFrame

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  TearDown : System.TimeoutException : "wait for health" timed out
Raw output
TearDown : System.TimeoutException : "wait for health" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()