Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix standardised score conversion failing for scores set with 0.0x mod mutliplier #26082

Merged
merged 2 commits into from Dec 23, 2023

Conversation

bdach
Copy link
Collaborator

@bdach bdach commented Dec 23, 2023

Closes #26073.

See inline comments for explanation of cause.

Because this only impacts "unranked" mods in stable vernacular, this change should not impact the ongoing score imports.

As suggested internally, this also includes a change which will make these sorts of failures much louder (007ea51).

@smoogipoo smoogipoo merged commit 807ea8a into ppy:master Dec 23, 2023
17 checks passed
@bdach bdach deleted the relax-legacy-score-conversion branch December 24, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local score entry has a large negative score
2 participants