Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite osu!taiko's time range computation logic to match 1:1 with stable #26781

Merged
merged 1 commit into from
Jan 30, 2024

Rewrite time range computation logic to be completely based on stable…

959cc7c
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

Rewrite osu!taiko's time range computation logic to match 1:1 with stable #26781

Rewrite time range computation logic to be completely based on stable…
959cc7c
Select commit
Failed to load commit list.
GitHub Actions / Test Results (Windows, MultiThreaded) failed Jan 29, 2024 in 0s

Test Results (Windows, MultiThreaded) ❌

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

5559 tests were completed in 1470s with 5505 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerInput 17✔️ 1❌ 12s
osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn 16✔️ 1❌ 3s

❌ osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerInput

✔️ TestConstructor
✔️ TestRewind
✔️ TestSpinHalfBothDirections
✔️ TestSpinOneDirectionThenChangeDirection(-180,540,1)
✔️ TestSpinOneDirectionThenChangeDirection(-180,900,2)
✔️ TestSpinOneDirectionThenChangeDirection(180,-540,1)
✔️ TestSpinOneDirectionThenChangeDirection(180,-900,2)
✔️ TestSpinSingleDirection(-180,0)
✔️ TestSpinSingleDirection(-360,1)
✔️ TestSpinSingleDirection(-540,1)
✔️ TestSpinSingleDirection(-720,2)
✔️ TestSpinSingleDirection(180,0)
✔️ TestSpinSingleDirection(360,1)
✔️ TestSpinSingleDirection(540,1)
✔️ TestSpinSingleDirection(720,2)
✔️ TestVibrateWithoutSpinningOffCentre
✔️ TestVibrateWithoutSpinningOnCentre
❌ TestVibrateWithoutSpinningOnCentreWithDoubleTime
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : spinner is missed: Expected: False
	  But was:  True

❌ osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn

✔️ TestConstructor
✔️ TestLeadInProducesCorrectStartTime(1000,0)
✔️ TestLeadInProducesCorrectStartTime(10000,-7830.0d)
✔️ TestLeadInProducesCorrectStartTime(2000,0)
✔️ TestLeadInProducesCorrectStartTime(3000,-830.0d)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-1000,-1000,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(-10000,-10000,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(0,0,True)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,False)
✔️ TestStoryboardProducesCorrectStartTimeFadeInAfterOtherEvents(1000,0,True)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-1000,-1000)
❌ TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000)
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -10000.0d +/- 100.0d
	  But was:  -9888.0403000000006d
	  Off by:   -111.95969999999943d
	
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(0,0)
✔️ TestStoryboardProducesCorrectStartTimeSimpleAlpha(1000,0)

Annotations

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.TestSceneSpinnerInput ► TestVibrateWithoutSpinningOnCentreWithDoubleTime 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : spinner is missed: Expected: False
    But was:  True
Raw output 
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : spinner is missed: Expected: False
  But was:  True

--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

Check failure on line 0 in TestResults-Windows-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Gameplay.TestSceneLeadIn ► TestStoryboardProducesCorrectStartTimeSimpleAlpha(-10000,-10000) 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -10000.0d +/- 100.0d
    But was:  -9888.0403000000006d
    Off by:   -111.95969999999943d
Raw output 
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : check first frame time: Expected: -10000.0d +/- 100.0d
  But was:  -9888.0403000000006d
  Off by:   -111.95969999999943d

--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
View more details on GitHub Actions