Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust default min result of SliderTailHit, remove override #26877

Merged
merged 2 commits into from
Feb 5, 2024

Fix tests

66aa41e
Select commit
Failed to load commit list.
Sign in for the full log view
Merged

Adjust default min result of SliderTailHit, remove override #26877

Fix tests
66aa41e
Select commit
Failed to load commit list.
GitHub Actions / Test Results (Linux, MultiThreaded) failed Jan 31, 2024 in 0s

Test Results (Linux, MultiThreaded) ❌

Tests failed

❌ TestResults-Linux-MultiThreaded.trx

5559 tests were completed in 1112s with 5505 passed, 2 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.TestSceneSliderSnaking 8✔️ 1❌ 2s
osu.Game.Tests.Visual.Online.TestSceneChatOverlay 21✔️ 1❌ 11s

❌ osu.Game.Rulesets.Osu.Tests.TestSceneSliderSnaking

✔️ TestConstructor
✔️ TestRepeatArrowDoesNotMove(False)
✔️ TestRepeatArrowDoesNotMove(True)
✔️ TestSnakingDisabled(0)
✔️ TestSnakingDisabled(1)
✔️ TestSnakingDisabled(2)
✔️ TestSnakingEnabled(0)
✔️ TestSnakingEnabled(1)
❌ TestSnakingEnabled(2)
	TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : get slider start position increased

❌ osu.Game.Tests.Visual.Online.TestSceneChatOverlay

✔️ TestBasic
✔️ TestChannelCloseButton
✔️ TestChannelSelection
✔️ TestChatCommand
✔️ TestChatHeight
✔️ TestChatReport
✔️ TestConstructor
✔️ TestHighlightOnAnotherChannel
✔️ TestHighlightOnCurrentChannel
✔️ TestHighlightOnLeftChannel
✔️ TestHighlightWhileChatNeverOpen
✔️ TestHighlightWithNullChannel
✔️ TestKeyboardCloseAndRestoreChannel
✔️ TestKeyboardNewChannel
❌ TestKeyboardNextChannel
	TearDown : System.TimeoutException : "wait for join completed" timed out
✔️ TestMultiplayerChannelIsNotShown
✔️ TestRemoveMessages
✔️ TestSearchInListing
✔️ TestShowHide
✔️ TestSlowLoadingChannel
✔️ TestTextBoxRetainsFocus
✔️ TestTextBoxSavePerChannel

Annotations

Check failure on line 0 in TestResults-Linux-MultiThreaded.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, MultiThreaded)

osu.Game.Rulesets.Osu.Tests.TestSceneSliderSnaking ► TestSnakingEnabled(2)

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
  TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : get slider start position increased
Raw output
TearDown : osu.Framework.Testing.Drawables.Steps.AssertButton+TracedException : get slider start position increased
--TearDown
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|66_0()
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)

Check failure on line 539 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Linux, MultiThreaded)

osu.Game.Tests.Visual.Online.TestSceneChatOverlay ► TestKeyboardNextChannel

Failed test found in:
  TestResults-Linux-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "wait for join completed" timed out
Raw output
TearDown : System.TimeoutException : "wait for join completed" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /home/runner/work/osu/osu/osu.Game/Tests/Visual/OsuTestScene.cs:line 539
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()