Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deselecting slider adding control points #27056

Merged
merged 3 commits into from Feb 10, 2024

Conversation

kongehund
Copy link
Contributor

closes #27055

Will no longer add control points if the selection has 2 or more objects.

@bdach
Copy link
Collaborator

bdach commented Feb 6, 2024

as per comment in issue thread, i'm not sure i agree with this solution.

@bdach
Copy link
Collaborator

bdach commented Feb 10, 2024

Seems fine to try this and see what the response it is I guess. Low effort fix so I'm fine with reviewing.

I did add test coverage though. If you should wish to continue PRing changes to editor I'd ask to include test coverage for all functionality whenever feasible.

@bdach bdach enabled auto-merge February 10, 2024 14:36
@bdach bdach merged commit 4b847b6 into ppy:master Feb 10, 2024
10 of 11 checks passed
@kongehund
Copy link
Contributor Author

I'd ask to include test coverage for all functionality whenever feasible.

Sure thing - I figured a one-line PR didn't warrant tests - I'll make sure to include tests in the future regardless of PR size from now.

@bdach
Copy link
Collaborator

bdach commented Feb 10, 2024

When it comes to the editor we've come to the conclusion over the years that PRs dealing with selection specifics and input handling specifically need test coverage always because it is way too easy to break an existing flow with another "small one-liner change".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to deselect a slider creates control points instead of deselecting
2 participants