Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve exception logging of unobserved exceptions via FireAndForget #27077

Merged
merged 1 commit into from Feb 10, 2024
Merged

Improve exception logging of unobserved exceptions via FireAndForget #27077

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 5 additions & 2 deletions osu.Game/Online/Multiplayer/MultiplayerClientExtensions.cs
View file
Open in desktop
Expand Up @@ -23,9 +23,12 @@ public static class MultiplayerClientExtensions

Debug.Assert(exception != null);

string message = exception.GetHubExceptionMessage() ?? exception.Message;
if (exception.GetHubExceptionMessage() is string message)
// Hub exceptions generally contain something we can show the user directly.
Logger.Log(message, level: LogLevel.Important);
else
Logger.Error(exception, $"Unobserved exception occurred via {nameof(FireAndForget)} call: {exception.Message}");

Logger.Log(message, level: LogLevel.Important);
onError?.Invoke(exception);
}
else
Expand Down