Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selected legacy skins crashing on zero-length hold notes #27138

Merged
merged 2 commits into from Feb 15, 2024
Merged

Fix selected legacy skins crashing on zero-length hold notes #27138

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36005a5
Fix selected legacy skins crashing on zero-length hold notes
bdach Feb 12, 2024
3108842
Merge branch 'master' into legacy-body-piece-crash
frenzibyte Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs
View file
Open in desktop
Expand Up @@ -243,7 +243,9 @@ protected override void Update()

bodySprite.FillMode = FillMode.Stretch;
// i dunno this looks about right??
bodySprite.Scale = new Vector2(1, scaleDirection * 32800 / sprite.DrawHeight);
// the guard against zero draw height is intended for zero-length hold notes. yes, such cases have been spotted in the wild.
if (sprite.DrawHeight > 0)
bodySprite.Scale = new Vector2(1, scaleDirection * 32800 / sprite.DrawHeight);
}

break;
Expand Down