Create key-presses when watching legacy Relax replays #27145
Conversation
| } | ||
|
|
||
| public void ApplyToPlayer(Player player) | ||
| { | ||
| if (osuInputManager.ReplayInputHandler != null) | ||
| { | ||
| hasReplay = true; | ||
| legacyReplay = ruleset.ReplayScore.ScoreInfo.IsLegacyScore; |
There was a problem hiding this comment.
Hmmmmm.....
On one side, I could get behind this in a sense, as this is a rather simple way to address this. That said, I'm not sure everyone else will agree...?
@ppy/team-client any strong opinions? not sure I have one. Maybe this is okay as a stopgap at least?
There was a problem hiding this comment.
the other way to go with this would be to force lazer to output replay frames even for relax scores.
I'm not entirely sure what you mean by this. For lazer replays, this is already the case. It's only legacy replays which do not have key-presses in the replay data.
There was a problem hiding this comment.
Yeah I got confused (had it backwards) and edited my comment in post sorry.
There was a problem hiding this comment.
This looks pretty okay to me.
Resolves #9560
osu!stable does not record key presses onto replays with Relax, so attempting to watch them back in lazer didn't work historically.
master
2024-02-12.12-13-21.mp4
PR
2024-02-12.12-56-36.mp4