-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for displaying "mapper" badge in comment section #27164
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5267e0a
Move comment author line to separate component
frenzibyte c4e3580
Add API models for comment page metadata
frenzibyte 72c6134
Include commentable object metadata in comments
frenzibyte 4d3b605
Add support for displaying "mapper" badges in comments
frenzibyte c24af5b
Add test coverage
frenzibyte d189fa0
Rename flag
bdach 8312f92
Use better value for alignment
bdach 68247fa
Fix typo in json property name
bdach 3f46e1a
Merge branch 'master' into comment-mapper-pill
bdach File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. | ||
// See the LICENCE file in the repository root for full licence text. | ||
|
||
using Newtonsoft.Json; | ||
|
||
namespace osu.Game.Online.API.Requests.Responses | ||
{ | ||
public class CommentableMeta | ||
{ | ||
[JsonProperty("id")] | ||
public long Id { get; set; } | ||
|
||
[JsonProperty("owner_id")] | ||
public long? OwnerId { get; set; } | ||
|
||
[JsonProperty("owner_title")] | ||
public string? OwnerTitle { get; set; } | ||
|
||
[JsonProperty("title")] | ||
public string Title { get; set; } = string.Empty; | ||
|
||
[JsonProperty("type")] | ||
public string Type { get; set; } = string.Empty; | ||
|
||
[JsonProperty("url")] | ||
public string Url { get; set; } = string.Empty; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh haha, this is the name I chose initially for the variable. It read slightly weird to me so I replaced
Without
withNo
.