Fix recent collection initialiser inspection #27167
Conversation
smoogipoo
force-pushed
the
fix-inspection
branch
from
ba63b5b
to
2981ebe
Compare
smoogipoo
changed the title
smoogipoo
changed the title
| Child = rulesetSkinProvider; | ||
| Child = new RulesetSkinProvidingContainer(Ruleset.Value.CreateInstance(), Beatmap.Value.Beatmap, Beatmap.Value.Skin) | ||
| { | ||
| requester |
There was a problem hiding this comment.
Was in the middle of leaving review on this.................
Feeling pretty bad about this. The fact that this is a framework container using C# collection initialiser syntax feels very footgunny.
Like the usual idiomatic way to write this is Child = requester, no?
What was wrong with the editorconfig suppression that was here before?
There was a problem hiding this comment.
Ah yeah. I wanted to get this PR out of the way because it was blocking me from looking at/merging others.
I've pushed the fix straight to master: a037dbf
What was wrong with the editorconfig suppression that was here before?
Doesn't seem necessary after all (and doesn't fix this issue, because it still wants to use the initializer). The issue is as the OP says.
As seen in https://github.com/ppy/osu/actions/runs/7896613956/job/21550875129?pr=27147
This appears to have come up because .NET
8.0.200has been made available to the CI runner, and we've only been using.100.It looks like what the inspection wants us to do here is something like...
Which is pretty 馃ぎ