Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log GlobalStatistics when exporting logs from settings #27242

Merged
merged 2 commits into from Mar 5, 2024

Conversation

Susko3
Copy link
Member

@Susko3 Susko3 commented Feb 19, 2024

@frenzibyte
Copy link
Member

Has there been a scenario where this change becomes helpful for it? I was weirded out that this PR is here with seemingly no prior discussion anywhere.

@Susko3
Copy link
Member Author

Susko3 commented Feb 20, 2024

I just accidentally stumbled onto GlobalStatistics.OutputToLog() and thought it would be useful information to have in logs.
Also, global statistic data is already available in sentry reports.

To me, this is useful for seeing which input events are happening at a glance, without having to ask follow-up questions, eg. in #26875 (comment). If I were to see a bunch of dropped events there, it would help narrow down the problem.

Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see why not, more logging is rarely bad

@bdach bdach merged commit 429fa8d into ppy:master Mar 5, 2024
11 of 17 checks passed
@Susko3 Susko3 deleted the log-global-statistics branch March 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants