Make slider path parsing more friendly with spans #27418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
reviewed
Feb 29, 2024
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
frenzibyte
approved these changes
Mar 19, 2024
huoyaoyuan
commented
Mar 19, 2024
| { | ||
| int startIndex = segmentsBuffer[i].StartIndex; | ||
| int endIndex = segmentsBuffer[i + 1].StartIndex; | ||
| controlPoints.AddRange(convertPoints(segmentsBuffer[i].Type, allPoints.Slice(startIndex, endIndex - startIndex), pointsBuffer[endIndex])); |
There was a problem hiding this comment.
Specifically, I think this particular case is better readable with range expression.
I don't have preference on other cases though.
There was a problem hiding this comment.
There have been multiple occurrences of the .. operator being used and us not liking it in review, I don't want that happening here so I changed it with the Slice method to move the PR forward.
|
Requesting a second pair of eyes before proceeding with a merge, the PR is good but I'm not sure if there's something I should've checked against before approval (like triggering a diffcalc command to make sure nothing has changed with beatmap parsing or something). |
|
!diffcalc |
|
Spreadsheets show no difference as well, so let's get this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to unblock #23282, this PR refactors slider parsing to not passing substrings around.
The majority of existing logic is preserved. The performance shouldn't change much with this PR, just ensuring there's no regression.
Before:
After: