Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix catch fruit position getting randomised when last fruit has zero position #27456

Merged
merged 2 commits into from Mar 5, 2024

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Mar 2, 2024

@bdach

This comment was marked as outdated.

@bdach
Copy link
Collaborator

bdach commented Mar 4, 2024

Spreadsheet: https://docs.google.com/spreadsheets/d/1PNDZckAVTv7aCEa61yfIKLpRnKJTJamBYq76RDg8J3k/edit#gid=821151723

@bdach bdach self-requested a review March 5, 2024 11:54
@bdach
Copy link
Collaborator

bdach commented Mar 5, 2024

Well, the case brought up in the issue looks fixed. I did a sampling of conversion mappings for the beatmaps shown in the spreadsheet (5 with biggest gains, 5 with biggest losses; among those 5 are: 3 HR, 1 HRDT, 1 HRHT) because I'm not doing them all by hand and it looks like while this won't fix all of them, it's an improvement for sure, so I'm going to call this good:

beatmap ID mods beatmap status
67732 HR Sakamoto Maaya - Loop (kodomonoyume) [Hard].osu ❌ still failing
2006563 HR Perfume - STAR TRAIN (eiri-) [Connection].osu ❌ still failing
34736 HR O-Zone - Dragostea Din Tei (Taiko Cut) (Zekira) [TaikOsu-Oni].osu ✅ fixed
67732 DT, HR Sakamoto Maaya - Loop (kodomonoyume) [Hard].osu ❌ still failing
67732 HT, HR Sakamoto Maaya - Loop (kodomonoyume) [Hard].osu ❌ still failing
326913 HR Dark PHOENiX - Last Remote - Type gamma (sjoy) [L18's Normal].osu ✅ fixed
862777 HR Sharlo - Eisou Youga ~Meikyou Shisui~ (Sharlo) [Normal].osu ❌ still failing
1803436 HR Eve - Anoko Secret (Nevo) [hyper's Hard].osu ✅ fixed
1241727 DT, HR Veritas Unae - ~DISK 1~ (100bit) [Hard].osu ✅ fixed
70086 HT, HR Innocent Key - Lunatic Red Eyes (termerys) [Rox's Diff].osu ✅ fixed

Looking at the remaining failures they'll be related to the other known issues anyhow (i.e. probably slider velocity inaccuracies that spiral into fruits becoming not-hyper while they should be or hyper while they shouldn't).

@bdach bdach merged commit f91423a into ppy:master Mar 5, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants