Fix resume overlay not appearing after pausing when mouse cursor is inside window but outside of actual playfield area #27896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide of actual playfield area Related to ppy#27871 (although does not actually fix the issue with the pause button, _if_ it is to be considered an issue - the problem there is that the gameplay cursor gets hidden, so the other condition in the modified check takes over). Regressed in ppy@bce3bd5. Reasoning for breakage is silent change in `this` when moving the `Contains()` check (`DrawableRuleset` will encompass screen bounds, while `OsuResumeOverlay` is only as big as the actual playfield).
smoogipoo
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosely related to #27871 (reply in thread) (although does not actually fix the issue with the pause button, if it is to be considered an issue - the problem there is that the gameplay cursor gets hidden, so the other condition in the modified check takes over).
Regressed in bce3bd5. Reasoning for breakage is silent change in
thiswhen moving theContains()check (DrawableRulesetwill encompass screen bounds, whileOsuResumeOverlayis only as big as the actual playfield).Not 100% sure this will be accepted given the discussion that happened on discord but because the change wasn't intentional I guess might as well put this through the review paces...?