Improve PathControlPointVisualiser performance
#28102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes regarding #21495.
cf313cd:
PathControlPointPieceis a single path now. Less drawables to create/maintain (way faster selection and less memory usage), less total textures (less drawcalls). Win win across the board. Yes, now we have bigger texture to redraw, but we are doing that with sliders anyway. Though I think a custom drawable can be implemented here, but that's for another day.e319a3e: in majority of cases all the control points are within the visible area so masking updates can be avoided.