Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cognition difficulty calculation rework: High AR part #28112

Open
wants to merge 112 commits into
base: master
Choose a base branch
from

refactoring and balancing

9b14156
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Cognition difficulty calculation rework: High AR part #28112

refactoring and balancing
9b14156
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Windows, SingleThread) failed May 18, 2024 in 0s

5788 passed, 10 failed and 52 skipped

Tests failed

❌ TestResults-Windows-SingleThread.trx

5850 tests were completed in 1363s with 5788 passed, 10 failed and 52 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest 10❌ 38ms

❌ osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest

❌ Test(0.14102693012101306d,2,"nan-slider")
	  Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
	  But was:  0.87101717360410869d
	  Off by:   -0.7299902434830956d
	
❌ Test(0.4250648023083879d,4,"very-fast-slider")
	  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
	  But was:  0.88827415406480137d
	  Off by:   -0.46320935175641348d
	
❌ Test(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.5166873935037983d
	  Off by:   -0.077999168390791018d
	
❌ Test(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.7137988235642512d
	  Off by:   -0.0033558384174581235d
	
❌ TestClassicMod(0.4250648023083879d,4,"very-fast-slider")
	  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
	  But was:  0.88827415406480137d
	  Off by:   -0.46320935175641348d
	
❌ TestClassicMod(1.4386882251130073d,54,"zero-length-sliders")
	  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
	  But was:  1.5166873935037983d
	  Off by:   -0.077999168390791018d
	
❌ TestClassicMod(6.710442985146793d,239,"diffcalc-test")
	  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
	  But was:  6.7137988235642512d
	  Off by:   -0.0033558384174581235d
	
❌ TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider")
	  Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
	  But was:  1.6139154114978009d
	  Off by:   -1.0632045834930657d
	
❌ TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders")
	  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
	  But was:  1.7961216664251749d
	  Off by:   -0.05294144820994795d
	
❌ TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test")
	  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
	  But was:  8.9766841402070572d
	  Off by:   -0.0023888698998906222d

Annotations

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.14102693012101306d,2,"nan-slider") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
    But was:  0.87101717360410869d
    Off by:   -0.7299902434830956d
Raw output 
  Expected: 0.14102693012101306d +/- 1.0000000000000001E-05d
  But was:  0.87101717360410869d
  Off by:   -0.7299902434830956d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(0.4250648023083879d,4,"very-fast-slider") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
    But was:  0.88827415406480137d
    Off by:   -0.46320935175641348d
Raw output 
  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
  But was:  0.88827415406480137d
  Off by:   -0.46320935175641348d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(1.4386882251130073d,54,"zero-length-sliders") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.5166873935037983d
    Off by:   -0.077999168390791018d
Raw output 
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.5166873935037983d
  Off by:   -0.077999168390791018d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23
   at InvokeStub_OsuDifficultyCalculatorTest.Test(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► Test(6.710442985146793d,239,"diffcalc-test") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.7137988235642512d
    Off by:   -0.0033558384174581235d
Raw output 
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.7137988235642512d
  Off by:   -0.0033558384174581235d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 23

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(0.4250648023083879d,4,"very-fast-slider") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
    But was:  0.88827415406480137d
    Off by:   -0.46320935175641348d
Raw output 
  Expected: 0.42506480230838789d +/- 1.0000000000000001E-05d
  But was:  0.88827415406480137d
  Off by:   -0.46320935175641348d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(1.4386882251130073d,54,"zero-length-sliders") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
    But was:  1.5166873935037983d
    Off by:   -0.077999168390791018d
Raw output 
  Expected: 1.4386882251130073d +/- 1.0000000000000001E-05d
  But was:  1.5166873935037983d
  Off by:   -0.077999168390791018d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35
   at InvokeStub_OsuDifficultyCalculatorTest.TestClassicMod(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClassicMod(6.710442985146793d,239,"diffcalc-test") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
    But was:  6.7137988235642512d
    Off by:   -0.0033558384174581235d
Raw output 
  Expected: 6.710442985146793d +/- 1.0000000000000001E-05d
  But was:  6.7137988235642512d
  Off by:   -0.0033558384174581235d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClassicMod(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 35

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(0.5507108280047351d,4,"very-fast-slider") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
    But was:  1.6139154114978009d
    Off by:   -1.0632045834930657d
Raw output 
  Expected: 0.55071082800473514d +/- 1.0000000000000001E-05d
  But was:  1.6139154114978009d
  Off by:   -1.0632045834930657d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(1.743180218215227d,54,"zero-length-sliders") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
    But was:  1.7961216664251749d
    Off by:   -0.05294144820994795d
Raw output 
  Expected: 1.743180218215227d +/- 1.0000000000000001E-05d
  But was:  1.7961216664251749d
  Off by:   -0.05294144820994795d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
   at InvokeStub_OsuDifficultyCalculatorTest.TestClockRateAdjusted(Object, Span`1)

Check failure on line 31 in osu.Game/Tests/Beatmaps/DifficultyCalculatorTest.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, SingleThread)

osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest ► TestClockRateAdjusted(8.974295270307167d,239,"diffcalc-test") 

Failed test found in:
  TestResults-Windows-SingleThread.trx
Error:
    Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
    But was:  8.9766841402070572d
    Off by:   -0.0023888698998906222d
Raw output 
  Expected: 8.9742952703071666d +/- 1.0000000000000001E-05d
  But was:  8.9766841402070572d
  Off by:   -0.0023888698998906222d

   at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29

1)    at osu.Game.Tests.Beatmaps.DifficultyCalculatorTest.Test(Double expectedStarRating, Int32 expectedMaxCombo, String name, Mod[] mods) in D:\a\osu\osu\osu.Game\Tests\Beatmaps\DifficultyCalculatorTest.cs:line 31
   at osu.Game.Rulesets.Osu.Tests.OsuDifficultyCalculatorTest.TestClockRateAdjusted(Double expectedStarRating, Int32 expectedMaxCombo, String name) in D:\a\osu\osu\osu.Game.Rulesets.Osu.Tests\OsuDifficultyCalculatorTest.cs:line 29
View more details on GitHub Actions