Skip to content

Fix double interpolation being applied when `applyOffsets=false`

Sign in for the full log view
GitHub Actions / Test Results (Windows, MultiThreaded) failed Oct 5, 2023 in 1s

Test Results (Windows, MultiThreaded) ❌

Tests failed

❌ TestResults-Windows-MultiThreaded.trx

5017 tests were completed in 1814s with 4998 passed, 4 failed and 15 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Gameplay.TestSceneStoryboardSamples 5✔️ 1❌ 10s
osu.Game.Tests.Visual.Editing.TestSceneEditorClock 3✔️ 1❌ 10s
osu.Game.Tests.Visual.Editing.TestSceneTapTimingControl 2✔️ 2❌ 2s

❌ osu.Game.Tests.Gameplay.TestSceneStoryboardSamples

✔️ TestConstructor
✔️ TestRetrieveSampleInSubFolder
✔️ TestRetrieveTopLevelSample
✔️ TestSampleHasLifetimeEndWithInitialClockTime
✔️ TestSamplePlaybackAtZero
❌ TestSamplePlaybackWithBeatmapHitsoundsOff
	TearDown : System.TimeoutException : "sample played" timed out

❌ osu.Game.Tests.Visual.Editing.TestSceneEditorClock

✔️ TestClampWhenSeekOutsideBeatmapBounds
✔️ TestConstructor
❌ TestStopAtTrackEnd
	TearDown : System.TimeoutException : "clock stopped at end" timed out: Expected: 229170.0d
	  But was:  229155.0d
	
✔️ TestWrapWhenStoppedAtTrackEnd

❌ osu.Game.Tests.Visual.Editing.TestSceneTapTimingControl

✔️ TestBasic
✔️ TestConstructor
❌ TestNoCrashesWhenNoGroupSelected
	TearDown : System.AggregateException : One or more errors occurred. (newValue must be finite, but is NaN. (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is NaN. (Parameter 'newValue')
❌ TestTapThenReset
	TearDown : System.AggregateException : One or more errors occurred. (newValue must be finite, but is NaN. (Parameter 'newValue'))
	  ----> System.ArgumentException : newValue must be finite, but is NaN. (Parameter 'newValue')

Annotations

Check failure on line 527 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Gameplay.TestSceneStoryboardSamples ► TestSamplePlaybackWithBeatmapHitsoundsOff 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "sample played" timed out
Raw output 
TearDown : System.TimeoutException : "sample played" timed out
--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 527
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()

Check failure on line 527 in osu.Game/Tests/Visual/OsuTestScene.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Editing.TestSceneEditorClock ► TestStopAtTrackEnd 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : System.TimeoutException : "clock stopped at end" timed out: Expected: 229170.0d
    But was:  229155.0d
Raw output 
TearDown : System.TimeoutException : "clock stopped at end" timed out: Expected: 229170.0d
  But was:  229155.0d

--TearDown
   at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
   at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
   at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
   at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
   at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in D:\a\osu\osu\osu.Game\Tests\Visual\OsuTestScene.cs:line 527
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()

Check failure on line 352 in osu.Game/Screens/Edit/Timing/WaveformComparisonDisplay.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Editing.TestSceneTapTimingControl ► TestNoCrashesWhenNoGroupSelected 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : System.AggregateException : One or more errors occurred. (newValue must be finite, but is NaN. (Parameter 'newValue'))
    ----> System.ArgumentException : newValue must be finite, but is NaN. (Parameter 'newValue')
Raw output 
TearDown : System.AggregateException : One or more errors occurred. (newValue must be finite, but is NaN. (Parameter 'newValue'))
  ----> System.ArgumentException : newValue must be finite, but is NaN. (Parameter 'newValue')
--TearDown
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at osu.Framework.Extensions.TaskExtensions.WaitSafely(Task task)
   at osu.Framework.Testing.TestScene.checkForErrors()
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
--ArgumentException
   at osu.Framework.Graphics.TransformableExtensions.PopulateTransform[TValue,TEasing,TThis](TThis t, Transform`3 transform, TValue newValue, Double duration, TEasing& easing)
   at osu.Framework.Graphics.TransformableExtensions.TransformTo[TThis,TValue](TThis t, String propertyOrFieldName, TValue newValue, Double duration, Easing easing)
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.WaveformRow.WaveformOffsetTo(Single value, Boolean animated) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 352
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.regenerateDisplay(Boolean animated) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 218
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.showFromTime(Double time, Boolean animated) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 189
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.showFromBeat(Int32 beatIndex) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 181
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.Update() in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 176
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass141_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)

Check failure on line 352 in osu.Game/Screens/Edit/Timing/WaveformComparisonDisplay.cs

See this annotation in the file changed.

@github-actions github-actions / Test Results (Windows, MultiThreaded)

osu.Game.Tests.Visual.Editing.TestSceneTapTimingControl ► TestTapThenReset 

Failed test found in:
  TestResults-Windows-MultiThreaded.trx
Error:
  TearDown : System.AggregateException : One or more errors occurred. (newValue must be finite, but is NaN. (Parameter 'newValue'))
    ----> System.ArgumentException : newValue must be finite, but is NaN. (Parameter 'newValue')
Raw output 
TearDown : System.AggregateException : One or more errors occurred. (newValue must be finite, but is NaN. (Parameter 'newValue'))
  ----> System.ArgumentException : newValue must be finite, but is NaN. (Parameter 'newValue')
--TearDown
   at osu.Framework.Testing.TestScene.checkForErrors()
   at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
--ArgumentException
   at osu.Framework.Graphics.TransformableExtensions.PopulateTransform[TValue,TEasing,TThis](TThis t, Transform`3 transform, TValue newValue, Double duration, TEasing& easing)
   at osu.Framework.Graphics.TransformableExtensions.TransformTo[TThis,TValue](TThis t, String propertyOrFieldName, TValue newValue, Double duration, Easing easing)
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.WaveformRow.WaveformOffsetTo(Single value, Boolean animated) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 352
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.regenerateDisplay(Boolean animated) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 218
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.showFromTime(Double time, Boolean animated) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 189
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.showFromBeat(Int32 beatIndex) in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 181
   at osu.Game.Screens.Edit.Timing.WaveformComparisonDisplay.Update() in D:\a\osu\osu\osu.Game\Screens\Edit\Timing\WaveformComparisonDisplay.cs:line 176
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
--- End of stack trace from previous location ---
   at osu.Framework.Platform.GameHost.<>c__DisplayClass141_0.<abortExecutionFromException>b__0()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Platform.ThreadRunner.RunMainLoop()
   at osu.Framework.Platform.GameHost.windowUpdate()
   at osu.Framework.Platform.GameHost.Run(Game game)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
--- End of stack trace from previous location ---
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
View more details on GitHub Actions