Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'd like to be able to log an error and optionally a stacktrace #12

Closed
devoncarew opened this issue Sep 27, 2018 · 3 comments
Closed

I'd like to be able to log an error and optionally a stacktrace #12

devoncarew opened this issue Sep 27, 2018 · 3 comments
Labels
Milestone

Comments

@devoncarew
Copy link
Contributor

Something speculatively like logError(channel, message, error, {stackTrace}), but likely w/ support for a function callback to actually populate the last three params.

This would coorespond to the message, error, and stackTrace params from https://api.dartlang.org/be/158704/dart-developer/log.html.

@devoncarew devoncarew changed the title I'd like to be able to log and error and optionally a stacktrace I'd like to be able to log an error and optionally a stacktrace Oct 2, 2018
@pq pq added the api label Oct 16, 2018
@pq pq added this to the 1.0 milestone Oct 17, 2018
@pq
Copy link
Owner

pq commented Oct 22, 2018

If we wanted to keep API minimal (and assuming #38 lands) we could log errors like so:

log('ouch!', level: 2000, data: errorObject, stackTrace: trace);

@devoncarew : how does that sound for 1.0?

@devoncarew
Copy link
Contributor Author

👍 sounds great

@pq
Copy link
Owner

pq commented Oct 22, 2018

Groovy. Key will be documenting. I'll add it to the punchlist.

@pq pq closed this as completed Oct 22, 2018
@pq pq mentioned this issue Oct 22, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants