Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v 1.0 doc punchlist #39

Open
4 tasks
pq opened this issue Oct 22, 2018 · 1 comment
Open
4 tasks

v 1.0 doc punchlist #39

pq opened this issue Oct 22, 2018 · 1 comment
Milestone

Comments

@pq
Copy link
Owner

pq commented Oct 22, 2018

docs for 1.0:

@pq pq added this to the 1.0 milestone Oct 22, 2018
@pq
Copy link
Owner Author

pq commented Oct 22, 2018

Regrading levels, @devoncarew adds:

Ah, to follow up on my review, somewhere in the API - where int level is defined - we should have some indication of what the appropriate values are. Perhaps just a pointer to the package:logging docs, and something like an example that an 'error' level maps to a value of 1000.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant