Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty integrating non-Doka plugins #11

Open
zlanich opened this issue May 13, 2020 · 2 comments
Open

Difficulty integrating non-Doka plugins #11

zlanich opened this issue May 13, 2020 · 2 comments

Comments

@zlanich
Copy link

zlanich commented May 13, 2020

Hey there, I saw a past issue that is related to my struggles with Filepond and cropping:

#1

For small startup projects and simpler use cases, I would like to get open source cropping plugins working with this, and I've attempted to get react-east-crop working so far:

https://github.com/ricardo-ch/react-easy-crop

My primary struggle with the minimal documentation seems to come down to the order of transforms being performed by the Image Transform plugin. I successfully converted the simple things like degrees to radians, but every attempt I've made at more complex matrix math to correct for the transforms order has lead me to a dead end.

I'm wondering if it's feasible to control the transform order when using the Image Edit plugin so we can make this easier on ourselves. Each cropper plugin clearly applies transforms in a specific order, and if we could could control the same aspect as it appears in the preview and the transform, we wouldn't all have to be guessing at matrix math and digging through undocumented code to reverse engineer these plugins to make another.

Thoughts?

Thanks!

@rikschennink
Copy link
Collaborator

rikschennink commented May 13, 2020

Hi,

Doka Image Editor and FilePond both save you countless hours of development work building something similar. FilePond does this for free, and to add image editing capabilities you pay a relatively small fee (when compared to the hourly wage of a developer).

I can imagine that for some projects (for example personal hobby projects or OS projects) Doka might not be a great fit so I'm working on a new version that will offer a more straightforward way to set image manipulation instructions. I'm also documenting how these instructions are applied to images which should make it easier to integrate other client-side plugins or serverside image manipulation scripts.

Unfortunately I can't free up time to document the existing code so feel free to share the information you gathered reverse engineering the current code in this thread for other devs.

@zlanich
Copy link
Author

zlanich commented May 13, 2020

@rikschennink If I get anywhere significant with it, I will look into a PR for documentation amendments. I will probably use Doka for this particular client. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants