Hangs on Firefox 52 #436
Comments
|
Thanks for reporting, not super concerned as Firefox 52 browser share is at 0.015%, still, it should detect that this browser is not supported. |
|
Yes, I agree it's a very low share browser. We have a demographic with old kit (that's part of what we're about). If I could show a message saying it wasn't supported because the browser was old, then they'd understand. |
|
I just tested this on https://pqina.nl/filepond/ and can't confirm the issue. Revert + Upload works as intended.
|
|
Which FF version was that? I just tried again using Browserstack FF52/W10, and Firefox still hangs for me on that demo. |
|
@edwh Firefox 52 on Windows 10, not sure why it hangs when you test it. Happy to test again later this week. |
|
Thanks. I don't think it's specific to Browserstack, as I had a report
from a real end-user on an old PC.
…------ Original Message ------
From: "Rik" <notifications@github.com>
To: "pqina/filepond" <filepond@noreply.github.com>
Cc: "Edward Hibbert" <edward@ehibbert.org.uk>; "Mention"
<mention@noreply.github.com>
Sent: 02/02/2020 16:36:20
Subject: Re: [pqina/filepond] Hangs on Firefox 52 (#436)
@edwh <https://github.com/edwh> Firefox 52 on Windows 10, not sure why
it hangs when you test it. Happy to test again later this week.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#436?email_source=notifications&email_token=AAAN26DX2BCOKCXGELBN4JDRA3ZAJA5CNFSM4KKE4I32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKR25SI#issuecomment-581152457>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN26EGUJMJTF2XNUH2Q33RA3ZAJANCNFSM4KKE4I3Q>.
|
|
I retested:
Result:
Maybe I'm doing something wrong? |
|
Thanks for your patience. What happens for you if you try the upload in
the Demo section lower down?
…------ Original Message ------
From: "Rik" <notifications@github.com>
To: "pqina/filepond" <filepond@noreply.github.com>
Cc: "Edward Hibbert" <edward@ehibbert.org.uk>; "Mention"
<mention@noreply.github.com>
Sent: 03/02/2020 07:52:57
Subject: Re: [pqina/filepond] Hangs on Firefox 52 (#436)
I retested:
Screenshot 2020-02-03 at 08 44 34
<https://user-images.githubusercontent.com/1132575/73634873-7f9daa80-4662-11ea-81bd-a335893575b9.png>
Result:
Kapture 2020-02-03 at 8 49 12
<https://user-images.githubusercontent.com/1132575/73634877-82989b00-4662-11ea-9c7c-d3d597f958e5.gif>
Maybe I'm doing something wrong?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#436?email_source=notifications&email_token=AAAN26D62RGPM5JIRFQDUOLRA7ENTA5CNFSM4KKE4I32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKS2RPI#issuecomment-581281981>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN26BK4RGTT5AIHH455ZLRA7ENTANCNFSM4KKE4I3Q>.
|
|
It only shows an issue when dropping an image. Seems to be the logic that generates the preview that is causing the issue. |
|
Ah, progress. I get it when browsing and selecting, but it might be the
same problem.
…------ Original Message ------
From: "Rik" <notifications@github.com>
To: "pqina/filepond" <filepond@noreply.github.com>
Cc: "Edward Hibbert" <edward@ehibbert.org.uk>; "Mention"
<mention@noreply.github.com>
Sent: 03/02/2020 08:19:18
Subject: Re: [pqina/filepond] Hangs on Firefox 52 (#436)
It only shows an issue when dropping an image. Seems to be the logic
that generates the preview that is causing the issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#436?email_source=notifications&email_token=AAAN26AFZWTDRGF7AGNIWKDRA7HQNA5CNFSM4KKE4I32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKS4VRQ#issuecomment-581290694>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN26DBL5C4XTGKLXHBTZ3RA7HQNANCNFSM4KKE4I3Q>.
|
|
Fixed in new release of image preview plugin. Update to Correction: |
|
Splendid. Thanks - I know it's an old version, but it'll make one of my
users feel surprised and grateful.
…------ Original Message ------
From: "Rik" <notifications@github.com>
To: "pqina/filepond" <filepond@noreply.github.com>
Cc: "Edward Hibbert" <edward@ehibbert.org.uk>; "Mention"
<mention@noreply.github.com>
Sent: 03/02/2020 09:41:34
Subject: Re: [pqina/filepond] Hangs on Firefox 52 (#436)
Fixed in new release of image preview plugin. Update to 4.6.2👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#436?email_source=notifications&email_token=AAAN26FUZUX7KP366CHZ5E3RA7RE5A5CNFSM4KKE4I32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKTEZ4A#issuecomment-581324016>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN26H5626UWQBGCQSWFBDRA7RE5ANCNFSM4KKE4I3Q>.
|
|
Glad to hear that :-) Please close the issue if you can confirm it's fixed. |
|
One quick question - how can I access the support() function via the Vue adaptor? It uses it internally but doesn't seem to expose it remotely, though I may be wrong. |
|
@edwh it doesn't currently expose it, a PR is welcome. If there's no |
|
Ok, thanks. That's unrelated to this one so I'll close it. Thanks very much for your attention. |
|
Did you mean 4.6.2? That release doesn't seem to exist. 4.6.1 exists and is recent, but I just tried that using the _pond property, and that still exists on FF 52. (Sorry to be a pain.) |
|
It's this plugin that was updated: https://github.com/pqina/filepond-plugin-image-preview The question about the |
|
Yes, I updated that plugin to 4.6.1, which seems to be the most recent - I assume 4.6.2 above was a typo. Then I tried to check if it was supported by testing the _pond property, which is the workaround suggested in pqina/vue-filepond#136 as a way of dealing with the absence of supported(). On FF52 that property still exists. Am I doing the wrong thing (apart from, obviously, not providing a PR to expose the supported() method)? |
|
Sorry yes, should be |
|
The Image Preview plugin has been updated in order to fix the issue so it should now render a preview on Firefox 52 without issues. |
|
I'm sorry, I misunderstood. When I test using 4.6.1 I still get the same hang, though. (I'm getting a bit annoying at this point - shall I stop?) |
|
No worries. That's weird, it worked in my test case, maybe test it in isolation (please note I haven't updated the FilePond product page yet). I can't retest this for now. |
|
I still see the same hang using the demo at https://pqina.nl/filepond/ . I'll let you get on with something more important for a bit :-). |
|
That's to be expected as it doesn't use the new version of the image preview plugin. |
|
Ah, I see - that is what you just said. I still see the problem on my code using the updated preview plugin. But as I say, this is getting to the point where it's a waste of your time. Thanks, though. |
Summary
FilePond hangs in uploading state on Firefox 52
How to reproduce
Use Firefox 52, either natively or via Browserstack.
Go to www.ilovefreegle.org
Click on Give
Enter a UK postcode e.g. PR3 2NX and click Next
Click Add Photos
Click the Browse button
Select a photo file
The entire browser locks at this point.
I haven't done a standalone demo because I think this is probably not related to my code - I see the same thing on https://codesandbox.io/s/github/KimGenius/React-file-pond/tree/master/?from-embed, for example.
Expected behaviour
File is uploaded and process callback is triggered.
This works on later versions of Firefox.
Additional information
I've checked the return from supported(), which returns true.
The text was updated successfully, but these errors were encountered: