Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper should allow prefixing #21

Closed
1 of 3 tasks
santiDotIO opened this issue Sep 24, 2019 · 3 comments
Closed
1 of 3 tasks

Helper should allow prefixing #21

santiDotIO opened this issue Sep 24, 2019 · 3 comments
Assignees

Comments

@santiDotIO
Copy link

santiDotIO commented Sep 24, 2019

Note: for support questions, please use stackoverflow. This repository's issues are reserved for feature requests and bug reports.

  • **I'm submitting a ... **

    • feature request
    • bug report
    • support request => Please do not submit support request here, see note at the top of this template.
  • Do you want to request a feature or report a bug?
    Most of the grid classes can be customized with the exception of the helper clases
    https://github.com/lucasgruwez/waffle-grid/wiki/Using-the-grid#helper-classes

  • What is the current behavior?
    Currently you cannot prefix these classes which creates conflicts with other packages.

  • What is the expected behavior?
    Allow to have a scss variable you can set to prefix helper classes/

@lucasgruwez
Copy link
Collaborator

Ah yes, I can see how that would conflict with other libraries...
I like the idea of adding an scss variable to prefix the helper classes and will implement it ASAP.

lucasgruwez added a commit that referenced this issue Sep 29, 2019
Added helper prefixes, now v1.3.6.
Also added sponsor button on repo, linking to paypal.me.
@lucasgruwez
Copy link
Collaborator

Done! v1.3.6, use $helper-prefix to set the prefix for the helper classes, for example, if its set to "waffle-", the classes would be .waffle-center, .waffle-m-hide, etc...

@santiDotIO
Copy link
Author

@lucasgruwez Awesome! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants