Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep scroll position on auto load #119

Closed
its-ermira opened this issue Mar 23, 2021 · 3 comments · Fixed by #121
Closed

Keep scroll position on auto load #119

its-ermira opened this issue Mar 23, 2021 · 3 comments · Fixed by #121
Assignees
@prabhuignoto
Labels
bug Something isn't working

Comments

@its-ermira
Copy link

Hi there!

On scroll end, I am loading more data to the timeline, and when loading is done, the scrollbar scrolls to the top of the timeline, which is a frustration and not user friendly because I'm loading the new data on the bottom.

Can scroll to the top be disabled for this use case?
@prabhuignoto prabhuignoto self-assigned this Mar 23, 2021
@prabhuignoto prabhuignoto added the enhancement New feature or request label Mar 23, 2021
@prabhuignoto
Copy link
Owner

@its-ermira can you let me know if there is a repo where i can reproduce this issue.

@its-ermira
Copy link
Author

its-ermira commented Mar 24, 2021 •
edited

@prabhuignoto Here's the issue reproduced
https://codesandbox.io/s/react-chrono-vertical-basic-forked-c9653

@prabhuignoto prabhuignoto added this to the 1.9.3 milestone Mar 24, 2021
@prabhuignoto prabhuignoto added bug Something isn't working and removed enhancement New feature or request labels Mar 24, 2021
@prabhuignoto prabhuignoto linked a pull request Apr 2, 2021 that will close this issue
1.9.3 fixes #121
Merged
prabhuignoto added a commit that referenced this issue Apr 2, 2021
@prabhuignoto
fix for #119 (keep the scroll position fixed on dynamic update)
be0a3e3
@prabhuignoto
Copy link
Owner

@its-ermira this has been fixed with the latest update. do check out and let me know how that works out for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prabhuignoto prabhuignoto

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1.9.3 fixes prabhuignoto/react-chrono
2 participants
@prabhuignoto @its-ermira