Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activeItemIndex is not respected in horizontal mode #258

Closed
danr-za opened this issue Jun 14, 2022 · 3 comments · Fixed by #262
Closed

activeItemIndex is not respected in horizontal mode #258

danr-za opened this issue Jun 14, 2022 · 3 comments · Fixed by #262
Assignees
@prabhuignoto
Labels
bug Something isn't working resolved resolved but open for confirmation

Comments

@danr-za
Copy link

danr-za commented Jun 14, 2022

Describe the bug
Setting activeItemIndex prop in horizontal mode is not setting the active item.
In vertical mode, it works as expected.

To Reproduce
Steps to reproduce the behavior:
Set activeItemIndex to an index that isn't the first.

Expected behavior
Should set the active item
@prabhuignoto prabhuignoto self-assigned this Jun 14, 2022
@prabhuignoto prabhuignoto added the bug Something isn't working label Jun 15, 2022
@prabhuignoto
Copy link
Owner

@danr-za do you a repo to reproduce this issue. i dont see this happening with the latest version.

@prabhuignoto prabhuignoto added the resolved resolved but open for confirmation label Jun 15, 2022
@omer-shlifka
Copy link

Hi, I can reproduce this bug as well..
With the latest version (1.17.0)

  • mode "HORIZONTAL"
  • scrollable: true
  • activeItemIndex: different than 0.
    What happens is the axis is focused on the active item correctly, but the cards view is not scrolled to the right card position.

Thanks!

prabhuignoto added a commit that referenced this issue Jun 25, 2022
@prabhuignoto
fix for #258
d6a0ac3
@prabhuignoto prabhuignoto mentioned this issue Jun 25, 2022
Merged
8 tasks
prabhuignoto added a commit that referenced this issue Jun 25, 2022
@prabhuignoto
Fix for #258 (#262)
6829fee 
chore: update packages
@prabhuignoto prabhuignoto linked a pull request Jun 25, 2022 that will close this issue
fix for #258 #262
Merged
8 tasks
@prabhuignoto
Copy link
Owner

@omer-shlifka this is now fixed with the latest version

@prabhuignoto prabhuignoto changed the title activeItemIndex is respected in horizontal mode activeItemIndex is not respected in horizontal mode Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prabhuignoto prabhuignoto

Labels
bug Something isn't working resolved resolved but open for confirmation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix for #258 prabhuignoto/react-chrono
3 participants
@prabhuignoto @danr-za @omer-shlifka