Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Added albums and item count to /albums #89

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Added albums and item count to /albums #89

merged 2 commits into from
Nov 24, 2021

Conversation

akshaypithadiya
Copy link
Collaborator

No description provided.

Copy link
Owner

@prabhuomkar prabhuomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also include error boundaries in this PR?

@@ -186,6 +185,10 @@ p {
justify-content: center !important;
}

.album-list-info {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't default justified as left?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. We have made it center for /explore which shows people name, places name etc. In center.

);
};

export default Favourites;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be albums?

}
`;

const Favourites = () => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename it to Albums 😛

@akshaypithadiya akshaypithadiya merged commit cac35c0 into master Nov 24, 2021
@akshaypithadiya akshaypithadiya deleted the issue-63 branch November 24, 2021 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants