Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade libtorch v2.0.0 #108

Merged
merged 3 commits into from Apr 2, 2023
Merged

Upgrade libtorch v2.0.0 #108

merged 3 commits into from Apr 2, 2023

Conversation

mfl28
Copy link
Collaborator

@mfl28 mfl28 commented Apr 1, 2023

Description of the change

  • Upgrades libtorch to 2.0.0 in CMake and Docker setup.
  • Updates available CUDA version options (11.7 and 11.8) for libtorch download via CMake.
  • Adds TORCH_CXX_FLAGS as in official documentation.
  • Explicitly adds -pthread to CMAKE_CXX_FLAGS on Linux, as without it, errors occur (missing reference to pthread_create) when compiling on Ubuntu 20.04 (at least in CI).
  • No tutorial code changes.

Type Of Change

  • New Feature

Related Issues

Closes #107 .

Development & Code Review

  • cpplint rules passes locally (run cmake -P cpplint.cmake)
  • CI is passing
  • Changes have been reviewed by at least one of the maintainers

@mfl28 mfl28 self-assigned this Apr 1, 2023
@mfl28 mfl28 requested a review from prabhuomkar as a code owner April 1, 2023 13:55
prabhuomkar
prabhuomkar reviewed Apr 2, 2023
View reviewed changes
README.md Show resolved Hide resolved
@prabhuomkar prabhuomkar merged commit a98e42d into prabhuomkar:master Apr 2, 2023
8 checks passed
@mfl28 mfl28 deleted the upgrade-libtorch-v2.0.0 branch December 8, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhuomkar prabhuomkar prabhuomkar approved these changes

Assignees

@mfl28 mfl28

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Upgrade to libtorch v2.0.0
2 participants
@mfl28 @prabhuomkar