Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min_product fix #347

Merged
merged 1 commit into from May 30, 2020
Merged

Conversation

Harshal96
Copy link

@Harshal96 Harshal96 commented May 3, 2020

Description

min_product was broken - variable name mismatch - fixed it.

Fixes # (issue)

There was a variable name mismatch.
count_negative should have been used instead of count_neg.
Removed an unused variable.
Also fixes one of the lint checks.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project i.e. Pep8
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • Any dependent changes have been merged and published in downstream modules
  • I have squashed unnecessary commits

@prabhupant prabhupant merged commit e04b841 into prabhupant:master May 30, 2020
@prabhupant
Copy link
Owner

Thanks for the PR 😄

@Harshal96
Copy link
Author

Harshal96 commented Jun 4, 2020

Thanks @prabhupant. I believe there are more PRs.
This is a good repository. Expect more PRs from me. :)

@prabhupant
Copy link
Owner

@Harshal96 appreciate it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants