Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra characters from code example #215

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

hkdobrev
Copy link
Contributor

There were some extra characters in a JSON code example.

There were some extra characters in a JSON code example.
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #215 (673a696) into main (bfa271c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   91.68%   91.68%           
=======================================
  Files          12       12           
  Lines         445      445           
  Branches       37       37           
=======================================
  Hits          408      408           
  Misses         37       37           
Flag Coverage Δ
app 91.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldbergyoni goldbergyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @hkdobrev !

@all-contributors please add @hkdobrev for docs

@goldbergyoni goldbergyoni merged commit 5b51984 into practicajs:main Aug 30, 2022
@goldbergyoni
Copy link
Contributor

goldbergyoni commented Aug 30, 2022

@all-contributors please add @hkdobrev for docs

@hkdobrev hkdobrev deleted the patch-1 branch August 30, 2022 10:21
@goldbergyoni
Copy link
Contributor

@all-contributors please add @rluvaton for code

@allcontributors
Copy link
Contributor

@goldbergyoni

I've put up a pull request to add @rluvaton! 🎉

@goldbergyoni
Copy link
Contributor

@all-contributors please add @hkdobrev for code

@allcontributors
Copy link
Contributor

@goldbergyoni

I've put up a pull request to add @hkdobrev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants