Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link (updating) #2

Closed
seancorfield opened this issue Oct 9, 2020 · 1 comment
Closed

Broken link (updating) #2

seancorfield opened this issue Oct 9, 2020 · 1 comment

Comments

@seancorfield
Copy link

Currently, Updating practicalli/clojure-deps-edn links to https://github.com/practicalli/clojure-deps-edn/blob/live/updating-practicalli/clojure-deps-edn which does not exist.

It looks like it should link to updating-practicalliclojure-deps-edn (without the /).

@practicalli-johnny
Copy link
Contributor

Yes, good catch. The / on the title is dropped when GitHub adds the Id

As the full URL in the rendered page is
https://github.com/practicalli/clojure-deps-edn#updating-practicalliclojure-deps-edn

I think changing the title by using a space instead of / will make a nicer Id name

practicalli-johnny added a commit that referenced this issue Oct 9, 2020
GitHub generates id's for titles based on names.  When a title contains a dash
character, that character is dropped.

The title Updating practicalli/clojure-deps-edn creates a hard to read id, so
changing the title to use a space

Updating the mini table of contents with the new link for the id.  This link is
currently broken

Resolves: #2
attamamnabil pushed a commit to attamamnabil/clojure-deps-edn that referenced this issue Oct 11, 2020
GitHub generates id's for titles based on names.  When a title contains a dash
character, that character is dropped.

The title Updating practicalli/clojure-deps-edn creates a hard to read id, so
changing the title to use a space

Updating the mini table of contents with the new link for the id.  This link is
currently broken

Resolves: practicalli#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants