New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with Meteor 1.2 #8
Comments
+1 on Wkwebview. Mobile web apps need all the performance it can get and this is a big boost over the previous webview. |
No, this package includes a modified version of Telerik's cordova wkwebview plugin, adopted for meteor (supporting meteor auto updates / hot code pushes). Problem is that I couldn't merge Telerik upstream with many bug fixes, including for most open bugs here, because they upgraded their cordova dependency to 5.0 and meteor was lagging behind. As soon as an official release of meteor comes out with 5.0 support, I'll merge Telerik's upstream and publish this one. |
And restating here, I'm not an Objective C developer, so I'm looking for help maintaining this with someone that knows Objective C. |
Hi @rbabayoff! Thanks for creating this plugin, desperately needed. Now that 1.2 is out with Cordova 5, any idea when you'll be able make the merge you described above? |
Hey @jamielob, will work on it this week. |
Thanks a lot! 🙏😄🙌 |
+1 waiting for a miracle ) |
+1 |
👍 this would be so useful! I would help but the Obj C seems over my head... |
+1 |
Hey @rbabayoff - is there somewhere I can buy you a couple beers/coffees online for your work on this? |
+1 |
1 similar comment
+1 |
How's this looking? |
hi @rbabayoff, how are you doing? Our team (flowkey) worked a lot with your package and we are also going to upgrade to 1.2, can you share the current state? I am sure we can support a little. What do you think? |
👍 |
1 similar comment
+1 |
Anyone else out there able to work on this? |
I've had a look at it, but I genuinely don't know what I'm doing with Objective C; seems like there's an uncaught exception when it starts the server: https://github.com/JamesLefrere/WKWebView Here's the test project I've been using: https://github.com/JamesLefrere/meteor-cordova-wkwebview-test To use it, change the package.js file here to point towards the cordova plugin on your local filesystem:
Any ideas, anyone?? Cheers PS: Xcode crying below:
|
Hey @JamesLefrere - are you trying to merge in the changes from Telerik's package into this one or start fresh? |
@jamielob This was based on merging in the new versions from Telerik, and I think there were some Meteor-related changes too (e.g. I had to import the CordovaUpdate header another way). It really did change a lot though, so maybe starting afresh could make sense (for someone with the ObjC skill). |
@JamesLefrere Thanks for your work on this! I just cloned down your repos and found that two versions of
After deleting the I tried to find where the additional file is coming from, but I'm not sure. |
@johnthepink - when it hangs has Meteor loaded? |
@johnthepink Sorry, I didn't notice that was still included in the package – I've been using the files in .meteor/local/cordova-build without trying a new 'meteor run ios' build. I've removed that file (and the entry in plugin.xml) and now it should build without the duplicate symbols, but similarly, it's hanging on the splash screen. @jamielob No, the local server is accessible (http://localhost:12344) but this does not appear to finish loading Meteor, and I can only (for example) put an alert() in cordova.js to see that that file has loaded. Could it be that it's looking for the wrong local port or address? |
@JamesLefrere Could you run meteor -v and post any errors that come up? |
Guys, I apologize, but i'm out of mobile development (for now), and I just don't have the time to maintain packages I'm not using internally. I'm also not an Objective C developer, and have asked for help from the community maintaining this package together with an Objective C developer, but haven't found one, as of yet. If anyone wants to pick up the slack, I'm willing to run them through the code, and get them up to speed on the package internals, so they can continue maintaining it. |
@rbabayoff Noooooooooooo, don't leave us here! Not sure if you saw my email, but I have a client willing to pay to get this working with 1.2. Don't suppose you'd be interested in getting it up and running before handing it off completely? |
FYI - spoke with @rbabayoff and my client's budget isn't going to cover it unfortunately. Hoping he'll be able to point us in the right direction here. |
POI: https://forums.meteor.com/t/meteor-1-2-ios-wkwebview/11055 Official support expected from next month. |
Thanks for the update. Official support sounds great
|
@joelpickup Thanks for the info, we might have to wait for that, then. My fork seems like it ought to be working, but no dice – the WKWebView is there, but it seems like Meteor isn't loaded by meteor_cordova_loader.js, and I'm not sure why. |
I did this really quick because we had some pressing issues on iOS 9 on a meteor 1.2 project. I've published it here: https://atmospherejs.com/silvervue/wkwebview It's working for our 1.2 application at the moment. I'm happy to generate a pull request, but I think the above changes will break 1.1. With Meteor 1.2 you do not have to update cordova as specified in the original instructions. In fact, you need to carefully extricate the update by removing it from your cordova-plugins file, and also remove the directories under .meteor/local/ except for 'db'. For a fresh 1.2 project, you should only have to: meteor add silvervue:wkwebview |
Thank you @thedracle! Looks like this will be a good stop gap until official support is released. |
@thedracle 👍 Fantastic work, well done! |
@thedracle thanks from me too! You saved me time. |
@thedracle I think you're right, better you publish this as your own package, for meteor 1.2 only. Since I'm out of mobile development, I don't have the time and resources to maintain this package, including testing and merging PRs. |
@rbabayoff, We'll continue to maintain this because it's intrinsic to our production application, until there is a direct meteor alternative. |
Meteor team just released Meteor 1.2-rc7, which includes the latest cordova integrations.
I thought this package is only to support a higher cordova version than Meteor used to support, so that we can use Wkwebview. Now that Meteor supports the latest cordova version, I thought I could just do
meteor add cordova:com.telerik.plugins.wkwebview@5.0.0
The package was added successfully, but the app crashed on iphone. After I removed the package, it started working again. Could you provide me with some insight to resolve this problem?
The text was updated successfully, but these errors were encountered: