feat: store calendars in db #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alissonpeloso
approved these changes
Jul 22, 2022
GuilhermeGraeff
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neste PR eu adicionei uma tabela no banco para salvar os calendários, para criar a tabela eu segui o modelo do json retornado pelo scraper. A ideia é que um job seja executado mensalmente para atualizar os calendários no banco mas essa frequência pode facilmente ser modificada caso necessário.
É necessário executar o comando
php artisan schedule:workpara que os eventos agendados sejam chamados e acredito que seja necessário aumentar o timeout doqueue:workequeue:listenjá que o scraper é um pouco demorado. É possível fazer isso usando o--timeout=tempona execução dos comandos.Para popular o banco pela primeira vez adicionei um seeder e também é possível fazer isso chamando o job por meio do tinker.
fix: #83