Changed maxProcessing defaults

for both batcher and loader as both operates on batches they have high processing time and are slow consumers
practo · Mar 4, 2021 · 6ea5b68 · 6ea5b68
1 parent 47489e2
commit 6ea5b68
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/redshiftsink/controllers/batcher_deployment.go b/redshiftsink/controllers/batcher_deployment.go
@@ -81,7 +81,7 @@ func NewBatcher(
 	// defaults for the batcher
 	var sessionTimeoutSeconds int = 10
 	var hearbeatIntervalSeconds int = 2
-	var maxProcessingSeconds float32 = 0.5
+	var maxProcessingSeconds float32 = 180 // batcher can be slow based on batch size
 
 	var groupConfigs []kafka.ConsumerGroupConfig
 	for groupID, group := range consumerGroups {

diff --git a/redshiftsink/controllers/loader_deployment.go b/redshiftsink/controllers/loader_deployment.go
@@ -100,7 +100,7 @@ func NewLoader(
 	// defaults for the loader
 	var sessionTimeoutSeconds int = 10
 	var hearbeatIntervalSeconds int = 2
-	var maxProcessingSeconds float32 = 0.5
+	var maxProcessingSeconds float32 = 600 // loader can be slow based on batch size
 
 	var groupConfigs []kafka.ConsumerGroupConfig
 	for groupID, group := range consumerGroups {