Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.1] bug With JSMin in mode "Performance" and "Normal" #808

Closed
zendre4 opened this issue Mar 25, 2022 · 5 comments
Closed

[PHP 8.1] bug With JSMin in mode "Performance" and "Normal" #808

zendre4 opened this issue Mar 25, 2022 · 5 comments

Comments

@zendre4
Copy link
Contributor

zendre4 commented Mar 25, 2022

When I pass my Prado application mode to "Performance" or "Normal" I have the following error (with PHP 8.1) :

2022-03-25_14-28

@ctrlaltca
Copy link
Member

Unfortunately that's a bug to be fixed in a 3rd party library used by prado.
The bug has already been reported here: mrclay/jsmin-php#10
Hopefully they will fix this soon.
I'll keep this ticket open to track its resolution.

@zendre4
Copy link
Contributor Author

zendre4 commented Mar 25, 2022

ok thanks

@ctrlaltca
Copy link
Member

So, i've come up with a temporary fix.
I've forked https://github.com/mrclay/jsmin-php into https://github.com/pradosoft/jsmin-php, added the required fix and tagged version 2.4.0-p1 of that library.
On prado master i've replaced the requirement of mrclay/jsmin-php with pradosoft/jsmin-php and tagged a new 4.2.0-alpha2 version.
If you composer-update you should pick up the new version including the needed fixes.
I hope i'll be able to test if any more change is needed for php 8.1 and release a proper version soon.

@zendre4
Copy link
Contributor Author

zendre4 commented Mar 29, 2022

Awesome !

Thx it's full working 👍🏻

@zendre4 zendre4 closed this as completed Mar 29, 2022
@ctrlaltca
Copy link
Member

https://github.com/mrclay/jsmin-php fixed the issue with php 8.1 and released jsmin-php 2.4.1.
I've switched back prado to their version of the library and tagged 4.2.0-alpha3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants