Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media query issue: max-width: $full-width #37

Closed
bastimeyer opened this issue Nov 21, 2020 · 6 comments
Closed

media query issue: max-width: $full-width #37

bastimeyer opened this issue Nov 21, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@bastimeyer
Copy link
Contributor

Describe the bug
In addition to #36, I've noticed an issue with the max-width: $full-width media query:

@media (max-width: $full-width)

This is without the width changes mentioned in #36, just default theme stylesheets.

Demonstration
https://youtu.be/mVmTa_k-UWk

It looks fine width-wise when using the browser's media query dev tools, but there's a gap of a couple of pixels which causes a horizontal scrollbar on the document body to appear.

Desktop (please complete the following information):

  • Arch Linux
  • Chromium
  • 87

Smartphone (please complete the following information):

Not tested

@bastimeyer bastimeyer added the bug Something isn't working label Nov 21, 2020
@pradyunsg
Copy link
Owner

What version of Furo is this, and could you share the exact Sphinx documentation to reproduce this?

@bastimeyer
Copy link
Contributor Author

The latest, otherwise I wouldn't have opened an issue.

You can reproduce it in your own documentation, like here for example:
https://pradyunsg.me/furo/customisation/

@pradyunsg
Copy link
Owner

Huh. I'm not able to reproduce this. I'll try this on browserstack later.

@pradyunsg
Copy link
Owner

Looks like Chrome includes the sidebar width when calculating how wide a page is. That... sucks. :)

Screenshot 2020-11-22 at 8 32 15 PM

@pradyunsg
Copy link
Owner

@pradyunsg
Copy link
Owner

Fixed in b06e7cf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants