Skip to content

Commit

Permalink
Implement Focus
Browse files Browse the repository at this point in the history
  • Loading branch information
@praeclarum
praeclarum committed Apr 19, 2018
1 parent 2317746 commit 3848e43
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 33 deletions.
62 changes: 32 additions & 30 deletions Documentation/OouiFormsStatus.md
View file
Expand Up @@ -4,7 +4,7 @@

The [ActivityIndicator](https://developer.xamarin.com/api/type/Xamarin.Forms.ActivityIndicator/) control gives a visual clue to the user that something is happening, without information about its progress.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
IsRunning | Done
Expand All @@ -14,7 +14,7 @@ Color | Pending

The UIActionSheet is a common UI element in iOS. The Xamarin.Forms [DisplayActionSheet](https://developer.xamarin.com/guides/xamarin-forms/application-fundamentals/navigation/pop-ups/) method lets you include this control in cross-platforms apps, rendering native alternatives.

Property | Status
Member | Status
------ | ------
Title | Pending
Cancel | Pending
Expand All @@ -25,7 +25,7 @@ Destruction | Pending

[BoxView](https://developer.xamarin.com/api/type/Xamarin.Forms.BoxView/) is a useful stand-in for images or custom elements when doing initial prototyping.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Color | Done
Expand All @@ -34,7 +34,7 @@ Color | Done

A [button](https://developer.xamarin.com/api/type/Xamarin.Forms.Button/) View that reacts to touch events.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
IsEnabled | Done
Expand All @@ -58,7 +58,7 @@ Released | Done

The Xamarin.Forms [CarouselPage](https://developer.xamarin.com/guides/xamarin-forms/application-fundamentals/navigation/carousel-page/) is a page that users can swipe from side to side to navigate through pages of content, like a gallery.

Property | Status
Member | Status
------ | ------
ItemsSource | Pending
ItemTemplate | Pending
Expand All @@ -80,7 +80,7 @@ Disappearing | Pending

A [ContentPage](https://developer.xamarin.com/api/type/Xamarin.Forms.ContentPage/) is a Page displaying a single View, often a container like a StackLayout or ScrollView.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Appearing | Done
Expand All @@ -90,7 +90,7 @@ DatePicker

The visual representation of a [DatePicker](https://developer.xamarin.com/api/type/Xamarin.Forms.DatePicker/) is very similar to the one of Entry, except that a special control for picking a date appears in place of a keyboard.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Format | Done
Expand All @@ -104,7 +104,7 @@ DateSelected | Pending

The [Editor](https://developer.xamarin.com/guides/xamarin-forms/user-interface/text/editor/) control is used to accept multi-line input.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
IsEnabled | Done
Expand All @@ -120,7 +120,7 @@ Completed | Done

[Entry](https://developer.xamarin.com/api/type/Xamarin.Forms.Entry/) is a single line text entry. It is best used for collecting small discrete pieces of information, like usernames and passwords.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
IsEnabled | Done
Expand All @@ -134,12 +134,14 @@ FontAttributes | Done
TextColor | Done
TextChanged | Done
Completed | Done
Focus | Done


### Frame

[Frame](https://developer.xamarin.com/api/type/Xamarin.Forms.Frame/) is an element containing a single child, with some framing options.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
OutlineColor | Done
Expand All @@ -150,7 +152,7 @@ HasShadow | Pending

[View](https://developer.xamarin.com/api/type/Xamarin.Forms.Image/) that holds an image.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Source | Done
Expand All @@ -165,7 +167,7 @@ Supported FileSource, StreamSource and UriSource.

A [Label](https://developer.xamarin.com/api/type/Xamarin.Forms.Label/) is used to display single-line text elements as well as multi-line blocks of text.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
IsEnabled | Done
Expand All @@ -185,7 +187,7 @@ YAlign | Done

An [ItemsView](https://developer.xamarin.com/api/type/Xamarin.Forms.ListView/) that displays a collection of data as a vertical list.

Property | Status
Member | Status
------ | ------
IsPullToRefreshEnabled | Pending
IsRefreshing | Pending
Expand Down Expand Up @@ -214,7 +216,7 @@ Refresing | Pending

A [Page](https://developer.xamarin.com/api/type/Xamarin.Forms.MasterDetailPage/) that manages two panes of information: A master page that presents data at a high level, and a detail page that displays low-level details about information in the master.

Property | Status
Member | Status
------ | ------
Detail | Pending
IsGestureEnabled | Pending
Expand All @@ -228,7 +230,7 @@ IsPresentedChanged | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.Maps.Map/) that shows a map provided by a platform-specific service.

Property | Status
Member | Status
------ | ------
Pins | Pending
MapType | Pending
Expand All @@ -242,7 +244,7 @@ MoveToRegion | Pending

A [Page](https://developer.xamarin.com/api/type/Xamarin.Forms.NavigationPage/) that manages the navigation and user-experience of a stack of other pages.

Property | Status
Member | Status
------ | ------
Animate | Pending
Add | Pending
Expand All @@ -252,7 +254,7 @@ Remove | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.OpenGLView/) that displays OpenGL content.

Property | Status
Member | Status
------ | ------
HasRenderLoop | Pending

Expand All @@ -261,7 +263,7 @@ HasRenderLoop | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.Picker/) control for picking an element in a list.

Property | Status
Member | Status
------ | ------
Title | Pending
SelectedIndex | Pending
Expand All @@ -275,7 +277,7 @@ SelectedIndexChanged | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.ProgressBar/) control that displays progress.

Property | Status
Member | Status
------ | ------
BackgroundColor | Pending
Progress | Done
Expand All @@ -285,7 +287,7 @@ ProgressTo | Pending

An [element](https://developer.xamarin.com/api/type/Xamarin.Forms.ScrollView/) capable of scrolling if its Content requires.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Orientation | Pending
Expand All @@ -300,7 +302,7 @@ Scrolled | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.SearchBar/) control that provides a search box.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
SearchCommand | Done
Expand All @@ -321,7 +323,7 @@ TextChanged | Done

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.Slider/) control that inputs a linear value.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Minimum | Done
Expand All @@ -333,7 +335,7 @@ ValueChanged | Done

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.Stepper/) control that inputs a discrete value, constrained to a range.

Property | Status
Member | Status
------ | ------
BackgroundColor | Pending
Minimum | Pending
Expand All @@ -346,7 +348,7 @@ ValueChanged | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.Switch/) control that provides a toggled value.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
IsToggled | Done
Expand All @@ -356,7 +358,7 @@ Toggled | Done

[Displays](https://developer.xamarin.com/api/type/Xamarin.Forms.TabbedPage/) an array of tabs across the top of the screen, each of which loads content onto the screen.

Property | Status
Member | Status
------ | ------
BarBackgroundColor | Pending
BarTextColor | Pending
Expand All @@ -375,7 +377,7 @@ PagesChanged | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.TableView/) that holds rows of Cell elements.

Property | Status
Member | Status
------ | ------
BackgroundColor | Pending
HasUnevenRows | Pending
Expand All @@ -388,7 +390,7 @@ ContextActions | Pending

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.TimePicker/) control that provides time picking.

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
Format | Done
Expand All @@ -399,7 +401,7 @@ Time | Done

A [View](https://developer.xamarin.com/api/type/Xamarin.Forms.WebView/) that presents HTML content.

Property | Status
Member | Status
------ | ------
CanGoBack | Pending
CanGoForward | Pending
Expand All @@ -412,13 +414,13 @@ Navigating | Pending

### VisualElement

Property | Status
Member | Status
------ | ------
BackgroundColor | Done
AnchorX | Done
AnchorY | Done
IsEnabled | Done
IsFocused | Done
IsFocused | Pending
IsVisible | Done
Opacity | Done
RotationX | Pending
Expand Down
21 changes: 18 additions & 3 deletions Ooui.Forms/Renderers/EntryRenderer.cs
View file
Expand Up @@ -39,8 +39,10 @@ protected override void Dispose (bool disposing)
_disposed = true;

if (disposing) {
if (Element != null) {
Element.FocusChangeRequested -= Element_FocusChangeRequested;
}
if (Control != null) {
//Control.Inputted -= OnEditingBegan;
Control.Input -= OnEditingChanged;
Control.Change -= OnEditingEnded;
}
Expand All @@ -53,9 +55,15 @@ protected override void OnElementChanged (ElementChangedEventArgs<Entry> e)
{
base.OnElementChanged (e);

if (e.OldElement != null) {
e.OldElement.FocusChangeRequested -= Element_FocusChangeRequested;
}

if (e.NewElement == null)
return;

e.NewElement.FocusChangeRequested += Element_FocusChangeRequested;

if (Control == null) {
var textField = new Ooui.TextInput ();
SetNativeControl (textField);
Expand All @@ -67,8 +75,6 @@ protected override void OnElementChanged (ElementChangedEventArgs<Entry> e)
_defaultTextColor = Colors.Black;

textField.Input += OnEditingChanged;

//textField.EditingDidBegin += OnEditingBegan;
textField.Change += OnEditingEnded;
}

Expand All @@ -81,6 +87,15 @@ protected override void OnElementChanged (ElementChangedEventArgs<Entry> e)
UpdateAlignment ();
}

void Element_FocusChangeRequested (object sender, VisualElement.FocusRequestArgs e)
{
if (e.Focus && Control != null) {
Control?.Focus ();
e.Result = true;
}
}


protected override void OnElementPropertyChanged (object sender, PropertyChangedEventArgs e)
{
if (e.PropertyName == Entry.PlaceholderProperty.PropertyName || e.PropertyName == Entry.PlaceholderColorProperty.PropertyName)
Expand Down
5 changes: 5 additions & 0 deletions Ooui/Element.cs
View file
Expand Up @@ -243,6 +243,11 @@ public void SetCapture (bool retargetToElement)
Call ("setCapture", retargetToElement);
}

public void Focus ()
{
Call ("focus");
}

void HandleStylePropertyChanged (object sender, PropertyChangedEventArgs e)
{
SendSet ("style." + Style.GetJsName (e.PropertyName), Style[e.PropertyName]);
Expand Down

0 comments on commit 3848e43

Please sign in to comment.