Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

.NET Framework Core modifications #8

Merged
merged 2 commits into from Mar 15, 2012

Conversation

2 participants
Collaborator

timheuer commented Mar 15, 2012

Trying again...on my fork it doesn't show harry formatting changes...

Owner

praeclarum commented Mar 15, 2012

Looks good to me! Thanks for all your effort.

Just a quick question:

Does DeclaredProperties also return inherited properties? I don't think many people use inheritance with their models, but I just want to keep compatibility.

@praeclarum praeclarum added a commit that referenced this pull request Mar 15, 2012

@praeclarum praeclarum Merge pull request #8 from timheuer/master
.NET Framework Core modifications
dd697a8

@praeclarum praeclarum merged commit dd697a8 into praeclarum:master Mar 15, 2012

Owner

praeclarum commented Mar 15, 2012

Also, just as a warning, I'm going to rename DeleteTable to DropTable. Others have implemented that functionality, and I like the name more than Delete.

Collaborator

timheuer commented Mar 15, 2012

I am checking on DeclaredProperties...


http://timheuer.com/blog/
twitter: @timheuer

On Thu, Mar 15, 2012 at 4:01 PM, Frank A. Krueger <
reply@reply.github.com

wrote:

Looks good to me! Thanks for all your effort.

Just a quick question:

Does DeclaredProperties also return inherited properties? I don't think
many people use inheritance with their models, but I just want to keep
compatibility.


Reply to this email directly or view it on GitHub:
#8 (comment)

Collaborator

timheuer commented Mar 15, 2012

DeclaredProperties does not include inherited

Owner

praeclarum commented Mar 15, 2012

Why Microsoft decided that System.Type needed refactoring, I'll never understand...

Owner

praeclarum commented Mar 15, 2012

The code should work fine if we switch it back to GetProperties (BindingFlags). Would you care to finish off your work here? Just make sure you resync with praeclarum/sqlite-net master as I'm making changes right now too.

Collaborator

timheuer commented Mar 15, 2012

You can't switch back got GetProperties (doesn't exist in .NETCore).

As to the reason for the refactoring...it's actually (in the end) a good
reason, but represents short-term pain for sure for framework developers.


http://timheuer.com/blog/
twitter: @timheuer

On Thu, Mar 15, 2012 at 4:33 PM, Frank A. Krueger <
reply@reply.github.com

wrote:

The code should work fine if we switch it back to GetProperties
(BindingFlags). Would you care to finish off your work here? Just make sure
you resync with praeclarum/sqlite-net master as I'm making changes right
now too.


Reply to this email directly or view it on GitHub:
#8 (comment)

Owner

praeclarum commented Mar 15, 2012

MSDN says GetProperties exists: http://msdn.microsoft.com/en-us/library/kyaxdd3x(v=vs.110).aspx

Or... .NET 4.5 and NETFX_CORE are two different things?

So how do you get the full inheritance chain of properties?

Whatever their reasons, it's an arbitrary change that is causing a lot of rewrites and #if code. There's quite simply no difference between type.Name and type.GetInfo ().Name.

I feel like I'm back to C++ with all these #ifs. I would LOVE for someone from MS to espouse what greater good that change has made in the Windows programming world.

Collaborator

timheuer commented Mar 15, 2012

Probably not the best place for a debate on the why's in this changeset :-)
(head to the forums and I'll point the team there)

GetProperties, yes is in full fx. You could use GetRuntimeProperties
extension method to get all including inherited and do a LINQ query on the
types.
On Thu, Mar 15, 2012 at 4:48 PM, Frank A. Krueger <
reply@reply.github.com

wrote:

MSDN says GetProperties exists:
http://msdn.microsoft.com/en-us/library/kyaxdd3x(v=vs.110).aspx

Or... .NET 4.5 and NETFX_CORE are two different things?

So how do you get the full inheritance chain of properties?

Whatever their reasons, it's an arbitrary change that is causing a lot of
rewrites and #if code. There's quite simply no difference between type.Name
and type.GetInfo ().Name.

I feel like I'm back to C++ with all these #ifs. I would LOVE for someone
from MS to espouse what greater good that change has made in the Windows
programming world.


Reply to this email directly or view it on GitHub:
#8 (comment)

Owner

praeclarum commented Mar 16, 2012

Not debating, just venting. They made a bad choice, but it's impossible now to undo it, so doesn't matter. :-)

I have no idea how you're even running this thing on Windows 8 - how you're linking to sqlite3. Please outline those steps or submit a patch fixing the bug. Thanks!

Collaborator

timheuer commented Mar 16, 2012

Which bug?

Owner

praeclarum commented Mar 16, 2012

The "table mapping doesn't include full inheritance chain on NETFX_CORE" bug.

@xperiandri xperiandri pushed a commit to xperiandri/sqlite-net that referenced this pull request Sep 12, 2015

@oysteinkrog oysteinkrog Merge pull request #8 from ichiohta/locateinterop
Locate the full path for the (Win32 sqlite) interop dll
6ba5f3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment