This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
Show organisation names and split users in Admin view #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review. |
|
|
|
@rudigiesler @KaitCrawford @jpaidoussi ready for review. |
| @@ -490,7 +490,7 @@ services.factory('UserService', ['$http', '$httpParamSerializer', ($http, $httpP | |||
| # Fetches non-partner users with optional activity statistics | |||
| #---------------------------------------------------------------------------- | |||
| fetchNonPartner: (withActivity = false) -> | |||
| params = {non_partner: true, with_activity: withActivity} | |||
| params = {non_partner: false, with_activity: withActivity} | |||
There was a problem hiding this comment.
false is the default value for non_partner, so we might as well use the fetchAll function here instead?
|
Just the one comment from me, looks good otherwise |
|
@rudigiesler ready for review again |
|
hrm, looking at this failing test now. |
jpaidoussi
pushed a commit
that referenced
this pull request
Aug 26, 2016
Restore contact groups on contact read page
|
@rudigiesler ready for review again |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admins should have a global view.