Add getting contact by field

[rudigiesler]

We want to be able to get a contact by specifying a specific field, for example msisdn. The queries should have the form ?q='msisdn=+1234'

[SteveBarnett]

@rudigiesler Do we match for a missing / present +?
I mean if someone searches for +123, would they see 123. And if they searched for +123 would they see 123 (i guess yes).

[rudigiesler]

@SteveBarnett Not at the moment. It's an exact match for now. We could do that, but it would make things a little more complicated (we would have to have different things for different field types, eg. msisdn we would have to look for +, but twitter_id we would have to look for @)

[rudigiesler]

I think the tests are failing due to the riak version, checking up on this.

[SteveBarnett]

@rudigiesler How about a shorter / simpler version: strip leading +s from msisdns and leading @s from twitter ids (strip from the thing that is thrown into the query, not from the field value itself, I mean)? Or do we do that already?

[jerith]

@SteveBarnett This does a Riak index query under the hood, so we can only look up exact values. We could manipulate the query string before we search, but we don't necessarily have + at the front of all MSISDNs, etc.

[hodgestar]

I think we could combine these two lines into if field not in self.delivery_classes.

[hodgestar]

And just use self.delivery_classes.keys() in the error message (perhaps sorted?).

[hodgestar]

@SteveBarnett @jerith @rudigiesler contact_field_for_addr which is called by contact_for_addr already ensures that msisdn values have a + on the left and does some sanity adjustments for Gtalk addresses.

[hodgestar]

Slightly radical suggestion -- long term we're trying to get rid of DELIVERY_CLASS in favour of address_types and the delivery_class isn't really relevant here -- we just want to look up a contact given a value for one of it's fields. I propose that we tweak the methods on the contact model in Vumi Go so that there is an underlying method contact_for_addr_field(field, value) that is called by the current contact_for_addr. We can then call that method here too and just keep a list of field names (maybe the field list could be a new tuple attribute on the Contact model).

@rudi Thoughts?

[rudigiesler]

@hodgestar: It is something we can do, but it will add a bunch of time to this already unplanned task. I'll leave the decision up to you as whether it is worth the extra time or not.

[hodgestar]

@rudi I think let's do this -- it's a little extra work, but it helps kill delivery classes, which is a worthy goal. (copied from Slack for the record).

[rudigiesler]

@hodgestar This is now using the new vumi-go things. Ready for review.

[hodgestar]

Can the call to normalize_addr be moved outside the try: block?

[hodgestar]

👍 as soon as Travis is happy.