This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Add getting contact by field #29
Merged
rudigiesler
merged 17 commits into
develop
from
feature/issue-29-add-getting-contact-by-field
Feb 9, 2015
Merged
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
efe3c10
Add delivery classes to contacts api
ba16618
Added ability to get contacts by parameter query
dcdd7cf
Added tests for invalid query parameters and formats
6d24cd1
Added test for getting page with query
7592fef
Added support to FakeGoContacts for parameter queries
bc4cb98
Fix doc strings.
9b0cc8d
Fix verified fake
b989f62
Add test for no contacts found in search.
f362560
Fix contacts API
5d28b4f
Update travis to install riak 1.4
1a19035
Sort list of address types for error.
651f10f
Update tests.
b955e4d
Sort fields in FakeContactsApi error message.
86c0589
Update contacts API to use new vumi-go find by addr field function.
5ea2082
Update tests.
1cc893f
Update verified fake.
67f5903
Move normalize_addr call to outside of try statement.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the call to
normalize_addr
be moved outside thetry:
block?