The validity period for a submit_sm is variable length #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Is there any chance you could add a test that demonstrates the issue? |
|
Sure. I'm a bit busy today, but should be able to get you one tomorrow. |
|
Woot! |
See SMPP v3.4 specification section 4.4.1.
SimonStJG
force-pushed
the
validity-period-should-be-variable-length
branch
from
28daa30
to
61f01aa
Compare
|
I've added a test. |
|
Thanks! Will merge once Travis build is done. 👍 |
hodgestar
added a commit
that referenced
this pull request
Mar 1, 2016
…ble-length The validity period for a submit_sm is variable length
|
@SimonStJG released in version 0.1.9 (https://pypi.python.org/pypi/python-smpp/0.1.9). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SMPP v3.4 specification section 4.4.1.