Skip to content
This repository has been archived by the owner on Feb 11, 2019. It is now read-only.

Commit

Permalink
updated with some TODO reminders, getDummyCoreLayers now a bit less c…
Browse files Browse the repository at this point in the history
…ryptic
  • Loading branch information
annasborysova committed Jul 1, 2015
1 parent 8b20d2d commit 2e736db
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
7 changes: 2 additions & 5 deletions vxyowsup/tests/test_whatsapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,7 @@

@staticmethod
def getDummyCoreLayers():
return (
YowLoggerLayer,
TestingLayer,
)[::-1]
return (TestingLayer, YowLoggerLayer,)

This comment has been minimized.

Copy link
@hodgestar

hodgestar Jul 1, 2015

Contributor

We don't need the last , here.



def TUMessage_to_PTNode(message):
Expand All @@ -49,6 +46,7 @@ def setUp(self):
self.testing_layer = self.transport.stack_client.network_layer

def assert_nodes_equal(self, node1, node2):
# TODO: test id explicitly
node2["id"] = node1["id"]
self.assertEqual(node1.toString(), node2.toString())

Expand Down Expand Up @@ -81,7 +79,6 @@ def send(self, data):
# data is yowsup.structs.protocoltreenode.ProtocolTreeNode
# receive from upper
# send to lower (no lower in this layer)
# print(data)
reactor.callFromThread(self.data_received.put, data)

def send_to_transport(self, text, to_address):
Expand Down
1 change: 1 addition & 0 deletions vxyowsup/whatsapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def handle_outbound_message(self, message):
log.info('Sending %r' % (message.to_json(),))
self.stack_client.send_to_stack(
message['content'], message['to_addr'] + '@s.whatsapp.net')
# TODO: set the remote-message-id to something more useful
return self.publish_ack(
message['message_id'], 'remote-message-id')

Expand Down

0 comments on commit 2e736db

Please sign in to comment.